Added feature to import media into a specific directory

[eri-trabiccolo]

possible fix for #146

Related wp-cli/wp-cli#5955

Question: Is the README.md automatically generated, or shall I update it manually?

[swissspidy]

Question: Is the README.md automatically generated

Yes it is

[eri-trabiccolo]

thanks @swissspidy it looked like but I wasn't sure :)

Oh ok, I see now the gh workflow :)

[codecov]

Codecov Report

❌ Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/Media_Command.php	89.65%	3 Missing ⚠️

📢 Thoughts on this report? Let us know!

[Copilot]

Pull request overview

This pull request adds a --destdir parameter to the wp media import command, allowing users to specify a custom directory for uploaded media files instead of using the default WordPress uploads directory. This addresses issue #146 and wp-cli/wp-cli#5955.

Changes:

• Added --destdir parameter documentation to the import command
• Implemented upload directory filtering to redirect imported files to the specified directory
• Added Behat test scenarios to verify the functionality with both relative and absolute paths

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File	Description
src/Media_Command.php	Added --destdir parameter, implemented add_upload_dir_filter and remove_upload_dir_filter methods, and integrated the filter into the import workflow
features/media-import.feature	Added test scenarios for importing files with custom directory (relative and absolute paths)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The add_upload_dir_filter method does not return the filter callback, but the calling code expects it to return a value that can be passed to remove_upload_dir_filter. Add a return statement at the end of the method to return the $custom_upload_dir_filter closure.

Suggested change

	add_filter( 'upload_dir', $custom_upload_dir_filter, PHP_INT_MAX, 0 );
	add_filter( 'upload_dir', $custom_upload_dir_filter, PHP_INT_MAX, 0 );
	return $custom_upload_dir_filter;

[Copilot]

The variable $custom_upload_dir_filter is referenced here but may not be defined if the destdir condition was never met in the loop above (line 421-422). This will cause an undefined variable warning in PHP. The variable should be initialized before the foreach loop starts.

[Copilot]

The test scenarios have gaps in coverage for the new --destdir feature:

1. No test for importing multiple files with --destdir to ensure the feature works correctly when processing multiple files in a single command
2. No test for importing remote files (URLs) with --destdir to verify the feature works for both local and remote files

Consider adding test cases to cover these scenarios.