Skip to content

Add @skipglobalargcheck for conflicting arguments#312

Merged
swissspidy merged 1 commit intomainfrom
add/skipglobalargcheck
Mar 4, 2026
Merged

Add @skipglobalargcheck for conflicting arguments#312
swissspidy merged 1 commit intomainfrom
add/skipglobalargcheck

Conversation

@swissspidy
Copy link
Member

This is a companion to wp-cli/wp-cli#6174, which warns when commands override global arguments such as --path and --url.

If done on purpose, @skipglobalargcheck can be used to disable the warning on a per-command basis.

@swissspidy swissspidy added this to the 2.1.24 milestone Mar 4, 2026
@swissspidy swissspidy requested a review from a team as a code owner March 4, 2026 09:55
@swissspidy swissspidy added command:core-multisite-install Related to 'core multisite-install' command command:core-download Related to 'core download' command command:core-install Related to 'core install' command labels Mar 4, 2026
Copilot AI review requested due to automatic review settings March 4, 2026 09:55
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

@github-actions github-actions bot added command:core Related to 'core' command scope:testing Related to testing labels Mar 4, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the WP-CLI command argument handling by providing a mechanism for developers to intentionally override global arguments without triggering warnings. It introduces a new annotation that, when applied to a command, signals that the command's use of a global argument is by design, thus improving the flexibility of command definitions while maintaining the integrity of the argument validation system.

Highlights

  • New Annotation for Global Argument Conflicts: Introduced the @skipglobalargcheck annotation to explicitly disable warnings for commands that intentionally reuse global arguments, such as --path and --url.
  • Suppression of Warnings: Applied the @skipglobalargcheck annotation to the check_update, is_installed, and multisite_convert methods within src/Core_Command.php to prevent warnings for their specific reuses of global arguments.
Changelog
  • src/Core_Command.php
    • Added @skipglobalargcheck annotation to the check_update method.
    • Added @skipglobalargcheck annotation to the is_installed method.
    • Added @skipglobalargcheck annotation to the multisite_convert method.
Activity
  • No activity has occurred on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@swissspidy swissspidy force-pushed the add/skipglobalargcheck branch from 05a4eed to ff82b11 Compare March 4, 2026 09:57

This comment was marked as resolved.

gemini-code-assist[bot]

This comment was marked as resolved.

@swissspidy swissspidy merged commit 71a1d29 into main Mar 4, 2026
59 checks passed
@swissspidy swissspidy deleted the add/skipglobalargcheck branch March 4, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:core Related to 'core' command command:core-download Related to 'core download' command command:core-install Related to 'core install' command command:core-multisite-install Related to 'core multisite-install' command scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants