fix(draw): normalize swimlane cell order - #1157
Merged
Merged
Conversation
Deploying plait with
|
| Latest commit: |
d067c46
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b50137a0.plait.pages.dev |
| Branch Preview URL: | https://codex-normalize-table-cells.plait.pages.dev |
Deploying plait-docs with
|
| Latest commit: |
d067c46
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8f23336e.plait-docs.pages.dev |
| Branch Preview URL: | https://codex-normalize-table-cells.plait-docs.pages.dev |
5 tasks
Collaborator
Author
|
Here is some additional context to make this PR easier to review. Root causeWhen a row or column is inserted in the middle of a swimlane, the newly created cells are appended to the end of the Changes
Test coverageThe tests now cover the actual swimlane transform behavior:
Local targeted tests: The main review points are whether normalization happens at the correct stage in |
nightt5879
approved these changes
Jul 22, 2026
nightt5879
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Could you add a changeset for this fix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.