Skip to content

ci: android + macos build jobs, fix iOS paths (closes #41, refs #32)#42

Open
LeslieOA wants to merge 1 commit into
feat/android-themefrom
feat/ci-android
Open

ci: android + macos build jobs, fix iOS paths (closes #41, refs #32)#42
LeslieOA wants to merge 1 commit into
feat/android-themefrom
feat/ci-android

Conversation

@LeslieOA
Copy link
Copy Markdown
Member

Summary

New jobs

  • `build-android` — ubuntu-latest, JDK 17 (Sora's TextMate AAR + the gradle plugin chain require it), android-actions/setup-android with platforms;android-35 + build-tools;35.0.0 (matches `compileSdkVersion 35` in our build.gradle). Runs `expo prebuild --platform android` (which runs our `app.plugin.js` withAppBuildGradle modifier, injecting coreLibraryDesugaring), then `./gradlew :app:assembleDebug`.
  • `build-macos` — replaces the placeholder comment that said "pending chore: macOS example app — editor in split-pane #17". macos-15, latest-stable Xcode, `gem install cocoapods` only (macos-app uses RN's first-party `spm_dependency` helper — no cocoapods-spm gem). pod install + xcodebuild against `MacosApp.xcworkspace`.

Fixes

Out of scope

Linting (no eslint config in the repo), unit tests (none yet), distribution / release builds.

🤖 Generated with Claude Code

CI hadn't run since the ios-app → expo-app rename (PR #34) and the
slug change (SourceEditorExampleiOS → SourceEditorExample). Latent
breakage; this catches it up plus adds the two missing platforms.

build-android (NEW)
- ubuntu-latest, JDK 17 (Sora's language-textmate AAR + the gradle
  plugin chain require it).
- android-actions/setup-android@v3 with platforms;android-35 +
  build-tools;35.0.0 to match android/build.gradle's
  compileSdkVersion 35.
- expo prebuild --platform android — runs our app.plugin.js
  withAppBuildGradle modifier, injects coreLibraryDesugaring into
  android/app/build.gradle.
- ./gradlew :app:assembleDebug.

build-macos (NEW — replaces the placeholder comment)
- macos-15, latest-stable Xcode (matches build-ios).
- gem install cocoapods only — macos-app uses RN's first-party
  spm_dependency helper, no cocoapods-spm needed.
- pod install + xcodebuild -workspace MacosApp.xcworkspace.

build-ios (FIX)
- example/ios-app → example/expo-app paths.
- xcworkspace + scheme renamed: SourceEditorExampleiOS →
  SourceEditorExample (driven by app.json name change in PR #34).

typecheck (FIX)
- example/ios-app → example/expo-app path for the example typecheck.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant