Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
* [#126](https://github.com/workos/workos-rust/pull/126) fix(generated): regenerate from spec

**Features**
* **[audit_logs](https://workos.com/docs/reference/audit-logs)**:
* Added `expired` to `AuditLogExportState`
2 changes: 1 addition & 1 deletion .last-synced-sha
Original file line number Diff line number Diff line change
@@ -1 +1 @@
23faa38318d596e581656934ed72c4a18476d742
56a015eaa3c5fb42a7dd77526c43953a971f4907
8 changes: 8 additions & 0 deletions .oagen-manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -2075,6 +2075,14 @@
"POST /user_management/radar_challenges": {
"sdkMethod": "create_radar_challenge",
"service": "user_management"
},
"GET /user_management/radar_challenges/{id}": {
"sdkMethod": "get_radar_challenge",
"service": "user_management"
},
"DELETE /user_management/redirect_uris/{id}": {
"sdkMethod": "delete_redirect_uris",
"service": "user_management"
}
Comment on lines +2083 to 2086

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The SDK method name delete_redirect_uris (plural) is inconsistent with the single-resource endpoint DELETE /user_management/redirect_uris/{id}. Every other DELETE /{resource}/{id} method in the manifest uses the singular form — for example delete_redirect_uri would align with the pattern. Using the plural form here may be confusing for callers who expect the method to delete one resource by ID.

Suggested change
"DELETE /user_management/redirect_uris/{id}": {
"sdkMethod": "delete_redirect_uris",
"service": "user_management"
}
"DELETE /user_management/redirect_uris/{id}": {
"sdkMethod": "delete_redirect_uri",
"service": "user_management"
}
Prompt To Fix With AI
This is a comment left during a code review.
Path: .oagen-manifest.json
Line: 2083-2086

Comment:
The SDK method name `delete_redirect_uris` (plural) is inconsistent with the single-resource endpoint `DELETE /user_management/redirect_uris/{id}`. Every other `DELETE /{resource}/{id}` method in the manifest uses the singular form — for example `delete_redirect_uri` would align with the pattern. Using the plural form here may be confusing for callers who expect the method to delete one resource by ID.

```suggestion
    "DELETE /user_management/redirect_uris/{id}": {
      "sdkMethod": "delete_redirect_uri",
      "service": "user_management"
    }
```

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

}
}
4 changes: 2 additions & 2 deletions tests/fixtures/audit_log_schema.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"object": "audit_log_schema",
"version": 1,
"targets": [
{
"type": "invoice"
}
],
"object": "audit_log_schema",
"version": 1,
"created_at": "2026-01-15T12:00:00.000Z"
}
9 changes: 1 addition & 8 deletions tests/fixtures/audit_log_schema_actor.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"metadata": {
"type": "object",
"properties": {
"role": {
"type": "string"
}
}
}
"metadata": {}
}
Loading