feat(generated): Add Pipes operations and models#122
Conversation
Greptile SummaryThis PR adds generated Pipes support for data integrations. The main changes are:
Confidence Score: 4/5The generated Pipes surface is mostly straightforward, but the update model has a payload serialization issue that prevents one documented operation from being expressed. The review is focused on generated models and endpoints, with a concrete serialization mismatch identified in the update data integration request body. src/models/update_data_integration.rs
What T-Rex did
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
src/models/update_data_integration.rs:17-18
**Cannot reset scopes**
`scopes` is documented as accepting `null` to reset provider defaults, but `Option<Vec<String>>` with `skip_serializing_if = "Option::is_none"` omits `None` instead of serializing JSON `null`. Calling `UpdateDataIntegration { scopes: None, .. }` sends no `scopes` field, so callers cannot perform the reset operation exposed by this model.
Reviews (1): Last reviewed commit: "chore(generated): add release notes frag..." | Re-trigger Greptile |
| #[serde(skip_serializing_if = "Option::is_none", default)] | ||
| pub scopes: Option<Vec<String>>, |
There was a problem hiding this comment.
Cannot reset scopes
scopes is documented as accepting null to reset provider defaults, but Option<Vec<String>> with skip_serializing_if = "Option::is_none" omits None instead of serializing JSON null. Calling UpdateDataIntegration { scopes: None, .. } sends no scopes field, so callers cannot perform the reset operation exposed by this model.
Artifacts
Repro: focused Rust test source that serializes UpdateDataIntegration with scopes None
- Contains supporting evidence from the run (text/x-rust; charset=utf-8).
Repro: cargo test output showing serialized JSON omits scopes
- Keeps the command output available without making the summary code-heavy.
Ran code and verified through T-Rex
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/models/update_data_integration.rs
Line: 17-18
Comment:
**Cannot reset scopes**
`scopes` is documented as accepting `null` to reset provider defaults, but `Option<Vec<String>>` with `skip_serializing_if = "Option::is_none"` omits `None` instead of serializing JSON `null`. Calling `UpdateDataIntegration { scopes: None, .. }` sends no `scopes` field, so callers cannot perform the reset operation exposed by this model.
How can I resolve this? If you propose a fix, please make it concise.
Summary
feat(pipes): Add Pipes operations and models
DataIntegrationCredentialsDto.CustomProviderDefinition.CreateDataIntegration.UpdateCustomProviderDefinition.UpdateDataIntegration.DataIntegration.DataIntegrationList.DataIntegrationListListMetadata.DataIntegrationCredential.DataIntegrationCustomProvider.DataIntegrationCredentialsType.CustomProviderDefinitionAuthenticateVia.UpdateCustomProviderDefinitionAuthenticateVia.DataIntegrationState.DataIntegrationCredentialType.DataIntegrationCustomProviderAuthenticateVia.GET /data-integrations.POST /data-integrations.GET /data-integrations/{slug}.PUT /data-integrations/{slug}.DELETE /data-integrations/{slug}.POST /user_management/users/{user_id}/connected_accounts/{slug}.PUT /user_management/users/{user_id}/connected_accounts/{slug}.Triggered by workos/openapi-spec@e350eb0
BEGIN_COMMIT_OVERRIDE
feat(pipes): Add Pipes operations and models (#122)
END_COMMIT_OVERRIDE