Fix FIN+data ACK/queue; FIN_WAIT_2 now transitions to TIME_WAIT#42
Fix FIN+data ACK/queue; FIN_WAIT_2 now transitions to TIME_WAIT#42gasbytes merged 6 commits intowolfSSL:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request consolidates TCP FIN packet handling logic and adds support for the FIN_WAIT_2 to TIME_WAIT state transition. The changes aim to fix FIN packet acknowledgment when FIN arrives with payload data and ensure proper state transitions during connection teardown.
Changes:
- Removed duplicate FIN handling code that processed FIN packets in two separate locations
- Added FIN_WAIT_2 to TIME_WAIT state transition (previously missing)
- Implemented special ACK calculation for FIN+data packets in ESTABLISHED state
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/wolfip.c | Consolidated FIN handling into single block; added FIN_WAIT_2→TIME_WAIT transition; restructured ACK calculation for FIN+data packets |
| src/test/unit/unit.c | Updated two existing tests to expect TIME_WAIT; added new test for ESTABLISHED state FIN+data handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
danielinux
force-pushed
the
fix-tcp-fin-wait
branch
from
465ad46 to
d613ddf
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
danielinux
force-pushed
the
fix-tcp-fin-wait
branch
from
ff893c9 to
a8f0111
Compare
- Remove premature FIN handling; accept FIN only when in-order - Add in-order/out-of-order FIN tests for ESTABLISHED/FIN_WAIT_1/2 - FIN_WAIT_2 now transitions to TIME_WAIT on in-order FIN
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 participants
fenrir H-1 + M-1