Conversation
…equence on number on LISTEN->SYN_RCVD transition
the same tuple already exists
operations (and, or etc...)
danielinux
previously approved these changes
Feb 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses additional fuzzer-found issues in the TCP/IP stack, focusing on wrap-safe TCP sequence arithmetic and more robust TCP connection state handling.
Changes:
- Introduces a helper for TCP sequence subtraction and uses it in OOO/recv trimming paths.
- Adjusts option parsing arithmetic to avoid unsigned underflow and initializes
snd_unaon SYN-RCVD. - Adds SYN duplicate-rejection logic and new unit regression tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/wolfip.c | Implements wrap-aware TCP sequence handling, SYN duplicate rejection, and SYN-RCVD initialization fixes. |
| src/test/unit/unit.c | Adds regression tests validating snd_una initialization and duplicate SYN behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cast. prevents implicit conversion when signed comparison are happening.
a SYN with different local_ip and same remote endpoint and port from being rejected incorrectly. so only truly identical connections are considered duplicates.
danielinux
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More fixes caught by the fuzzers.