Skip to content

[BottomTabsCustomRow] Fix crash attaching custom row to non-AppCompat activities #8337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yedidyak merged 1 commit into from
Jul 30, 2026
Merged

[BottomTabsCustomRow] Fix crash attaching custom row to non-AppCompat activities #8337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions android/src/main/java/com/reactnativenavigation/customrow/BottomTabsCustomRowAttacher.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ internal object BottomTabsCustomRowAttacher : Application.ActivityLifecycleCallb
}

private fun tryAttach(activity: Activity) {
val scanRoot = activity.window?.decorView as? ViewGroup
?: activity.findViewById<View>(android.R.id.content) as? ViewGroup
?: return
val overlayHost = activity.findViewById<View>(android.R.id.content) as? ViewGroup
val scanRoot = activity.window?.decorView as? ViewGroup ?: return
// Resolve through the view tree: AppCompatActivity.findViewById() forces
// createSubDecor(), which throws unless the activity's theme is Theme.AppCompat.
val overlayHost = scanRoot.findViewById<View>(android.R.id.content) as? ViewGroup
?: scanRoot

forEachBottomTabs(scanRoot) { bottomTabs ->
Expand Down