RFC: Migrate to Vite+, second attempt.#229
Closed
cpojer wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
cc @FredKSchott |
Member
|
not a priority atm, can revisit in a couple of weeks, appreciate the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I figured I'll follow-up with a solution so you can take a look at it and make a decision, but I'm fine either way if you don't want to adopt Vite+ at this time.
The initial PR was reverted with this feedback:
I changed this PR so that package.json
scriptsstick around, andpnpmcan be used same asvpin this repo. It still uses the localvpbinary part of thevite-pluspackage, but should no longer require a new global.I was too conservative on the knip setup changes at first, and changed it to be less work to maintain.
I can't argue with that! However, this repo only uses Biome for linting, and is using Prettier for formatting. If you'd like to proceed with this PR, I can either leave it as is or disable linting in Vite+ and bring back Biome. It still unifies and standardizes a lot of other tooling.
Original PR:
This PR moves the flue repo to Vite+. Please see https://viteplus.dev/ for how to set up Vite+.
vp install, using pnpm under the hood.vite.config.ts, and should be used viavp check --fix.vite-plus/packinstead oftsdown.vite-plus/testinstead ofvitest.vp check.apps/www/package-lock.json, which I assume was there by accident.Overall, this gives a common toolchain to flue with a single
vite.config.tsconfiguration file, and everything is fast.