Repository navigation
Lecture 1 exercises and typo fixes in Lectures 1-3 - #3
Merged
Merged
Conversation
… Lecture 1 Three new exercise cells, without solutions: the distribution of the p-value under H0 (continuous vs discrete counts), the gain from categorizing and combining channels, and the bias of the maximum likelihood estimator of an exponential rate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Correct misspellings (Exercize, explicitely, hypotesis, ...), wrong ROOT class names in the text (AsymtoticCalculator, SetOneSideDiscovery) and evident grammar mistakes. Rename get_confiderence_poisson to get_confidence_poisson. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
One moderate correctness issue and several remaining prose issues are unresolved.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds three Lecture 1 exercises and corrects spelling, grammar, ROOT references, and a helper-function name across Lectures 1–3.
Changes:
- Added exercises on p-value distributions, categorization, and MLE bias.
- Corrected lecture prose and comments.
- Renamed
get_confiderence_poissonconsistently.
| File | Review notes |
|---|---|
Lecture3.ipynb |
Remaining grammar and wording issues at lines 976/2430, 993, 1010, and 1947. |
Lecture2.ipynb |
Remaining fragment, notation ambiguity, and subject–verb agreement issues at lines 317, 808, and 812. |
Lecture1.ipynb |
The MLE bias result should state the required condition (n>1) at line 536. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Fix the remaining grammar issues flagged in review, use lambda_up (not n_up) for the upper edge of the excluded region, and state that the bias of 1/t-bar is only defined for n > 1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
AsymptoticCalculator,SetOneSidedDiscovery), and renameget_confiderence_poisson→get_confidence_poisson(definition and both call sites).Only markdown text, comments and that one function name change; no logic changes.
Test plan
🤖 Generated with Claude Code