Conversation
|
Further research showed we can just have callback hooks for the metrics but for for some wierd reason prometheus exposes api as float even though it uses uint64 internally. Also although I disabled the default metrics there are some useful info DetailsDo we want that too @wind-c ? Or does it feel like too much noise? |
|
You have added quite a lot of code. I will need some time to review it! Thank you very much for your exploration. Let's work together! |
|
reminder @wind-c please check once you get time |
|
Sorry, I've been too busy recently. Could you please attach a screenshot of the visualization indicator effect? @sansmoraxz |
Did not get you. Could you explain what exactly you want. It's just publishing metrics here. Do you want something like grafana dashboards? Dashboards aren't part of this PR, only the tools to build it are. |
|
Just show me the actual results of adding Prometheus observability! |
|
Ohh check below: DetailsFrom my local server: http://localhost:8080/metrics |
|
I have taken these from here: Lines 16 to 38 in 0949432 |
|
Thanks! |
Exploring some more examples I saw callbacks is also an option. Wierd thing is they use float for API access even though internally it stores as atomic uint64.
Fixes: #136