Add additional center position names#124
Open
borjafac wants to merge 2 commits into
Open
Conversation
Extend sideview_position_names with four new center-aligned entries: center_left, center_top, center_right, and center_bottom. This enables finer-grained center positioning for the sideview plugin (ensure SIDEVIEW_POSITION_COUNT is updated accordingly where needed).
wheaney
requested changes
May 27, 2026
wheaney
requested changes
May 27, 2026
Owner
wheaney
left a comment
wheaney
left a comment
There was a problem hiding this comment.
We'll also want to update the xr_driver_cli since it provides a sideview option
Add additional sideview placement names and expose them in the CLI. The -svp/--sideview-position option now accepts middle_center, middle_left, top_center, middle_right and bottom_center in addition to the existing corners. Updated src/plugins/sideview.c to replace the old "center*" names with the new naming (center -> middle_center, center_left -> middle_left, center_top -> top_center, center_right -> middle_right, center_bottom -> bottom_center) so the names align with the CLI.
Author
|
Changes requested done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend sideview_position_names with four new center-aligned entries: center_left, center_top, center_right, and center_bottom. This enables finer-grained center positioning for the sideview plugin (ensure SIDEVIEW_POSITION_COUNT is updated accordingly where needed).