Harden OIDC callback redirect handoff against open redirects - #12
Merged
Merged
Conversation
Co-authored-by: wechuli <15605874+wechuli@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code scanning alert(s) flagged in repository
Harden OIDC callback redirect handoff against open redirects
Sep 18, 2026
wechuli
marked this pull request as ready for review
September 18, 2026 10:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OIDC callback flow could preserve an absolute external
nextURL at the final handoff step, creating an open-redirect sink after successful authentication. This change re-validates the stored redirect target at the redirect sink and adds a regression test for hostile absolute URLs.Redirect sink hardening
transaction.nextinside the callback handoff before constructing the final destination URL.Regression coverage
https://evil.example.test/phish.