Repository navigation
Conversation
5 tasks done
webern
marked this pull request as ready for review
October 29, 2026 07:10
<staff-details> kept <staff-lines> but dropped every <staff-tuning>, so a guitar tab came back with its lines and no record of what the strings are tuned to. StaffData gains staffTunings, a list of the new StaffTuningData (line, step, alter, cents, octave). Like staffLines, it is set on the measure whose attributes carry the staff-details. The reader fills it and the writer emits the tunings between staff-lines and staff-size. The tuning-step, tuning-alter and tuning-octave translation is shared with the existing scordatura reader and writer through TuningFunctions.h, with no change to scordatura behavior or diagnostics. musuite/testTablature1.xml, testTablature2.xml and testTablature3.xml now round-trip and are pinned in the baseline.
webern
force-pushed
the
m/mxdev-stafftune
branch
from
October 30, 2026 08:15
6dd2e37 to
67358c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<staff-details>kept<staff-lines>but dropped every<staff-tuning>, so a guitar tab cameback with its lines and no record of what the strings are tuned to.
StaffDatagainsstaffTunings, a list of the newStaffTuningData(line, step, alter, cents,octave). Like
staffLines, it is set on the measure whose attributes carry the staff-details andis not carried forward to later measures. The reader honours the
numberattribute on<staff-details>, and reads a<staff-details>that holds only tunings. The writer emits thetunings between
<staff-lines>and<staff-size>, as the schema orders them.The tuning-step / tuning-alter / tuning-octave translation is shared with the existing scordatura
reader and writer through a small header-only helper (
TuningFunctions.h), with no change toscordatura behavior or diagnostics. A separate
StaffTuningDatatype rather than reusingAccordData: a staff tuning has a required line, an accord an optional string number.musuite/testTablature1.xml,testTablature2.xmlandtestTablature3.xmlnow round-trip and arepinned in the baseline.
lysuite/ly71e_TabStaves.xmlandrecsuite/BrookeWestSample.xmllosetheir tuning differences but still fail on other staff-details content (staff-type, capo,
show-frets, line-detail), which is not modeled here.
Testing
MeasureDataTestcases: tuning round trip, alter and cents, tunings without staff-lines,two staves; new
MeasureWriterTestcase for the written<staff-tuning>make api-testpasses (6195 assertions in 716 test cases)make api-roundtrippasses, 445 of 445 pinned filesmake api-roundtrip-discover: 445 pass, no file that passed before now failsCMAKE_UNITY_BUILD_BATCH_SIZE=0) of themxtarget compilesmake fmt-checkpassesReferences