fix: do not forward geckoDriverVersion as a CLI argument to geckodriver binary#732
Merged
christian-bromann merged 1 commit intoJul 2, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes start() so geckoDriverVersion is used only to select/download the correct geckodriver binary and is no longer forwarded to the geckodriver process as a CLI flag (which geckodriver rejects as an unknown argument).
Changes:
- Exclude
geckoDriverVersionfrom the argument object passed toparseParams()/cp.spawn(). - Continue passing
geckoDriverVersionthrough to the downloader when a download is required. - Add a unit test asserting the version is used for download but not emitted as a geckodriver CLI argument.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/index.ts |
Removes geckoDriverVersion from spawned CLI args while still using it for driver download. |
tests/start-unit.test.ts |
Adds coverage to prevent regressions where geckoDriverVersion becomes a CLI arg. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
2
to
6
| import cp from 'node:child_process' | ||
| import { vi, test, expect } from 'vitest' | ||
| import { type GeckodriverParameters, start } from '../src/index.ts' | ||
| import { download } from '../src/install.js' | ||
|
|
christian-bromann
approved these changes
Jul 2, 2026
christian-bromann
merged commit 81f1824
into
webdriverio-community:main
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #webdriverio/webdriverio#15359