agent: add Taobao shop hosts and name the in-shop search toggle - #2646
Merged
Conversation
Live anonymous check on taobao.com turned up two hosts the matcher missed: store.taobao.com (shop browse; a bad shop id redirects there and the page renders without login) and shopsearch.taobao.com (shop search). Both are surfaces the in-shop search bullet is written for. Also add passport.taobao.com alongside login., and cover the Tmall cart/trade/my siblings the alternation already reached but the notes did not list. Name the in-shop search toggle as "搜本店" / "搜全站" instead of describing it, per the CONTRIBUTING rule that notes should carry the visible string. The labels are second-hand rather than observed — Taobao's search and shop-search both wall anonymous traffic at login.taobao.com — so the bullet keeps a structural fallback for the case where the labels are absent or renamed. Verified live on www.taobao.com: the main search button is "搜索", and the login wall shows "密码登录" and "手机扫码登录", so the existing "扫码登录" substring holds. Leaves the JD adapter's "搜全站"/"搜本店" alone. It came from a contributor who browsed the site, which outranks second-hand recall; it needs a live check before anyone changes it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2639.
Host coverage
A live anonymous pass over taobao.com turned up two real hosts the matcher missed:
store.taobao.com— shop browse. A non-existent shop id redirects here (store.taobao.com/shop/noshop.htm, "没有找到相应的店铺信息") and the page renders without login, so part of the shop surface is anonymously reachable.shopsearch.taobao.com— shop search.Both are surfaces the in-shop search bullet was written for, which is exactly the defect
CONTRIBUTING.mdnow warns about. Also addspassport.taobao.comnext tologin., and lists the Tmallcart/trade/mysiblings that the alternation already reached but the notes did not mention.In-shop search label
#2639 shipped a structural description ("carry their own in-shop search box scoped to that seller") because the literal could not be verified. This names it as
"搜本店"/"搜全站"and keeps a fallback clause for when the labels are absent.Provenance, so the next person can weigh it: the labels are second-hand, not observed. Taobao walls anonymous traffic at
login.taobao.com/havanaone/login/login.htmfor both product search and shop search, and I did not log in. The bullet therefore degrades gracefully rather than betting everything on the string.Verified live (anonymous)
www.taobao.commain search button is搜索— matches the existing note.密码登录,手机扫码登录,短信登录— the note's扫码登录holds as a substring.login.taobao.com/havanaone/login/login.htmis the real redirect target, as the adapter already says.Deliberately not changed
The JD adapter's
搜全站/搜本店pair. There is a second-hand claim that JD actually labels these本店/全部, but the current wording came from a contributor who browsed the site, and first-hand observation outranks recall. It needs a live check before anyone edits it — flagging rather than churning it.Validation
node test/run.js: 1398/1399. The one failure is the pre-existingCHANGELOG.md(26.0.0) vspackage.json(26.0.3) check that also fails onmain.node test/security/injection-corpus.mjs: 60/60.taobaoblocks byte-identical;git diff --checkclean.store.taobao.com.phishing.example,item.taobao.com@evil.com,shopabc.taobao.com, andrule.taobao.comall still rejected.