Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #499.
Problem
After a release, the docs homepage keeps showing the previous version (1.0.9 was live as
v1.0.8). A release triggers the docs workflow twice — themainbranch merge (which resolves the previous version viagit describe, since the tag isn't pushed yet) and the tag push (~90s later, correct version). Both create agithub-pagesdeployment seconds apart, and Pages kept the earlier branch-push artifact live even though the tag run deployed last and succeeded. #491 misdiagnosed this as stale JS chunk caching; the served HTML itself is the older build.Change
useLatestRelease), so the displayed version is correct regardless of which Pages artifact is live. A smallFALLBACK_RELEASEcovers SSR / first paint and is overridden by the fetch.Resolve release tag+Stamp release placeholderssteps and the full-history checkout (only needed for stamping).tagstrigger — tags no longer change deployed content, which eliminates the double-deploy race entirely.Notes
Once merged, a docs deploy (any docs push or a manual
workflow_dispatch) will publish and the live site self-corrects to the true latest release.