layout: Ensure that anonymous flex items are properly stored in a BoxSlot
#57199
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 16, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
force-pushed
the
servo_export_41951
branch
3 times, most recently
from
f14679c to
0ec3d05
Compare
…xSlot` When a flex container has text children, those children are wrapped in an anonymous box and used as flex items. These anonyous blocks must be stored into `BoxSlot`s so that their style is repairable during incremetnal layout. Signed-off-by: Martin Robinson <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_41951
branch
from
0ec3d05 to
c184eeb
Compare
servo-wpt-sync
added
stale-servo-export
Collaborator
Author
|
⛔ The downstream PR has merged (servo/servo#41951), but these changes could not be merged properly. Please address any CI issues and try to merge manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a flex container has text children, those children are wrapped in
an anonymous box and used as flex items. These anonymous boxes must be
stored into
BoxSlots so that their style is repairable duringincremental layout.
Testing: This change includes a new WPT test.
Fixes: #41947.
Reviewed in servo/servo#41951