WIP add retries to create data for consistency#167
Open
DanielJanicek wants to merge 1 commit intomainfrom
Open
WIP add retries to create data for consistency#167DanielJanicek wants to merge 1 commit intomainfrom
DanielJanicek wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This error shows in some CI jobs https://github.com/weaviate/weaviate-e2e-tests/actions/runs/24739340905/job/72374934517#step:15:651
==================================== ERRORS ====================================
_ ERROR at setup of test_delete_read_repair_http_request[novector_timebasedresolution_class] _
self = <weaviate.connect.v4.ConnectionSync object at 0x7fa8bed27150>
request = collection: "Read_repair_testpy_test_delete_read_repair_http_requestnovector_timebasedresolution_class_2"
tenant: "test-tenant-0"
objects_count: true
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/weaviate/connect/v4.py:1083:
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/weaviate/retry.py:54: in with_exponential_backoff
raise e
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/weaviate/retry.py:50: in with_exponential_backoff
return f(*args, **kwargs)
^^^^^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/grpc/_channel.py:1159: in call
return _end_unary_response_blocking(state, call, False, None)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
state = <grpc._channel._RPCState object at 0x7fa8a4635e90>
call = <grpc._cython.cygrpc.SegregatedCall object at 0x7fa8a46365c0>
with_call = False, deadline = None
E grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
E status = StatusCode.UNKNOWN
E details = "aggregate: shard not found"
E debug_error_string = "UNKNOWN:Error received from peer {grpc_status:2, grpc_message:"aggregate: shard not found"}"
E >
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/grpc/_channel.py:990: _InactiveRpcError
During handling of the above exception, another exception occurred:
request = <SubRequest 'collection_fixture' for <Function test_delete_read_repair_http_request[novector_timebasedresolution_class]>>
tests/recovery/python_recovery/read_repair_test.py:245:
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/_pytest/fixtures.py:539: in getfixturevalue
fixturedef = self._get_active_fixturedef(argname)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/_pytest/fixtures.py:627: in _get_active_fixturedef
fixturedef.execute(request=subrequest)
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/_pytest/fixtures.py:1110: in execute
result: FixtureValue = ihook.pytest_fixture_setup(
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/pluggy/_hooks.py:512: in call
return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/pluggy/_manager.py:120: in _hookexec
return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/pluggy/_callers.py:53: in run_old_style_hookwrapper
return result.get_result()
^^^^^^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/pluggy/_callers.py:38: in run_old_style_hookwrapper
res = yield
^^^^^
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/_pytest/setuponly.py:36: in pytest_fixture_setup
return (yield)
^^^^^
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/_pytest/fixtures.py:1202: in pytest_fixture_setup
result = call_fixture_func(fixturefunc, request, kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/_pytest/fixtures.py:908: in call_fixture_func
fixture_result = next(generator)
^^^^^^^^^^^^^^^
tests/recovery/python_recovery/read_repair_test.py:148: in novector_timebasedresolution_class
collection = _create_base_collection(
tests/recovery/python_recovery/read_repair_test.py:98: in _create_base_collection
DataManager(client).create_data(
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/weaviate_cli/managers/data_manager.py:978: in create_data
inserted, collection = _ingest_one_tenant(tenant)
^^^^^^^^^^^^^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/weaviate_cli/managers/data_manager.py:923: in _ingest_one_tenant
_initial = len(col.with_tenant(tenant))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/weaviate/collections/collection/sync.py:148: in len
total = self.aggregate.over_all(total_count=True).total_count
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/weaviate/collections/aggregations/over_all/executor.py:115: in over_all
return executor.execute(
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/weaviate/connect/executor.py:99: in execute
return cast(T, exception_callback(e))
^^^^^^^^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/weaviate/connect/executor.py:38: in raise_exception
raise e
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/weaviate/connect/executor.py:80: in execute
call = method(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^
self = <weaviate.connect.v4.ConnectionSync object at 0x7fa8bed27150>
request = collection: "Read_repair_testpy_test_delete_read_repair_http_requestnovector_timebasedresolution_class_2"
tenant: "test-tenant-0"
objects_count: true
E weaviate.exceptions.WeaviateQueryError: Query call with protocol GRPC search failed with message <_InactiveRpcError of RPC that terminated with:
E status = StatusCode.UNKNOWN
E details = "aggregate: shard not found"
E debug_error_string = "UNKNOWN:Error received from peer {grpc_status:2, grpc_message:"aggregate: shard not found"}"
E >.
/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/weaviate/connect/v4.py:1096: WeaviateQueryError
I believe there is a race in create_data when auto tenant creation is on, as the producer-consumer task queue can have either a stale tenant list or a tenant list with tenants that have not propogated yet.