Conversation
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
| * | ||
| * This is a destructive operation. The index will need to be regenerated if you wish to use it again. | ||
| * | ||
| * @param {keyof V & string} [vectorName] The name of the vector to drop the index from. If not provided, the default vector index will be dropped. |
There was a problem hiding this comment.
| * @param {keyof V & string} [vectorName] The name of the vector to drop the index from. If not provided, the default vector index will be dropped. | |
| * @param {keyof V & string} [vectorName] The name of the vector to drop the index from. If not provided, the "default" vector index will be dropped. |
Maybe a nit, but I think it's good to be specific about the fact that Weaviate doesn't have the notion of a default vector index, and it's the client that will fallback to "default" input. E.g. if the user's only index is called "my-only-index" they should expect to see an error on dropVectorIndex(undefined).
I would argue this parameter should be required tho, similarly to how when you're trying to delete a GH repo you need to manually enter the repo's name to confirm. Not insisting on it tho, just my first response to vectorName?.
| await expect(collection.config.dropVectorIndex('nonexistent')).rejects.toThrow( | ||
| 'The request to Weaviate failed with status code: 422 and message: {"error":[{"message":"not found: vector index \\"nonexistent\\" not found in class \\"TestDropNonExistentNamedVectorIndex\\""}]}' |
There was a problem hiding this comment.
Does the client generally throws errors on the 200+ HTTP codes? If yes, then it seems like this test is redundant, it essentially tests the server's response to a non-existen input. If no, then let's not assert the contents of the message -- someone may re-phrase that in v1.38 or sth and fail the client pipeline (used to happen a lot in the Java client test suite)
2 participants
No description provided.