Skip to content

Deprecated FluentForm hook fluentform_before_insert_submission used in FluentForms integration #405

Description

@jamil-mahmud

Description

weMail's FluentForms integration registers an action on fluentform_before_insert_submission, which has been deprecated since FluentForm v4.3.22 in favor of fluentform/before_insert_submission.

Every form submission on a site running both plugins emits a PHP deprecation notice, polluting debug.log. After tracing the source via grep, the issue is on weMail's side — not FluentForm's.

Log output

PHP Deprecated: Hook fluentform_before_insert_submission is deprecated since version 4.3.22!
Use fluentform/before_insert_submission instead.

Source

includes/Core/Form/Integrations/Hooks.php:

add_action( 'fluentform_before_insert_submission', array( FluentForms::instance(), 'submit' ), 999, 1 );

Suggested fix

Replace the hook name with the new slash-style version:

add_action( 'fluentform/before_insert_submission', array( FluentForms::instance(), 'submit' ), 999, 1 );

It may also be worth grepping the rest of the plugin for other fluentform_* hook usages that have been renamed in recent FluentForm versions.

Environment

  • weMail: 2.1.1
  • FluentForm: 6.9.4
  • PHP: 8.2

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions