Add a mousedown handler to also signal user activity in the app

[Copilot]

mousedown activity signaling was structured such that async telemetry concerns leaked into event handling. This change moves fire-and-forget behavior to the model boundary and keeps telemetry failures non-fatal.

• mousedown handler path

  • AppKeyHandlers now calls GlobalModel.getInstance().setIsActive() directly (no async wrapper in the handler).

• GlobalModel.setIsActive structure

  • setIsActive() is now synchronous (void).
  • Throttle logic remains unchanged.
  • Electron telemetry call is executed via util.fireAndForget(...) inside setIsActive().

• Telemetry error containment

  • getApi().setIsActive() is wrapped in try/catch inside the fire-and-forget callback.
  • Errors are logged with console.log("setIsActive error", e) and do not bubble.

• Focused coverage

  • Added frontend/app/store/global-model.test.ts for:
    • fire-and-forget invocation + throttling behavior
    • error logging/swallowing on rejected telemetry call

setIsActive(): void {
    const now = Date.now();
    if (now - this.lastSetIsActiveTs < GlobalModel.IsActiveThrottleMs) {
        return;
    }
    this.lastSetIsActiveTs = now;
    util.fireAndForget(async () => {
        try {
            await getApi().setIsActive();
        } catch (e) {
            console.log("setIsActive error", e);
        }
    });
}

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

[cloudflare-workers-and-pages]

Deploying waveterm with    Cloudflare Pages

Latest commit:	4cf6221
Status:	⚡️  Build in progress...

View logs

[kilo-code-bot]

WARNING: Missing error handling for IPC call

The getApi().setIsActive() call could fail (e.g., if the IPC channel is unavailable). Since this is a non-critical activity tracking feature called in a fire-and-forget manner, consider adding a try-catch to prevent unhandled promise rejections:

async setIsActive(): Promise<void> {
    const now = Date.now();
    if (now - this.lastSetIsActiveTs < GlobalModel.IsActiveThrottleMs) {
        return;
    }
    this.lastSetIsActiveTs = now;
    try {
        await getApi().setIsActive();
    } catch (e) {
        // Silently ignore errors for non-critical activity tracking
    }
}

[kilo-code-bot]

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	0
SUGGESTION	1

Issue Details (click to expand)

SUGGESTION

File	Line	Issue
frontend/app/store/global-model.ts	61	Unnecessary arrow function wrapper in fireAndForget call

Files Reviewed (5 files)

• frontend/app/store/global-model.ts - 1 issue
• frontend/app/app.tsx - No issues
• emain/emain-ipc.ts - No issues
• emain/preload.ts - No issues
• frontend/types/custom.d.ts - No issues

---

Fix these issues in Kilo Cloud

[kilo-code-bot]

WARNING: Test expectation doesn't match actual error logging

The test expects console.log("setIsActive error", error) but the actual implementation uses fireAndForget() which logs "fireAndForget error" instead (see frontend/util/util.ts:179).

The test should expect:

expect(logSpy).toHaveBeenCalledWith("fireAndForget error", error);

[kilo-code-bot]

SUGGESTION: Unnecessary arrow function wrapper

The fireAndForget function expects a function that returns a Promise. Since getApi().setIsActive() already returns a Promise<void>, you can pass it directly without the arrow function wrapper:

Suggested change

	util.fireAndForget(() => getApi().setIsActive());
	util.fireAndForget(getApi().setIsActive);

This is more concise and avoids creating an unnecessary closure.