Conversation
Member
|
Thank you for the PR! Please update the option to be a Parameter fields with a UI toggle instead of a config file option. |
mtthsbrd
force-pushed
the
feature/terminal-qr-code
branch
from
September 11, 2026 06:14
18ac96c to
df8415a
Compare
Contributor
Author
|
Updated as requested!
|
mtthsbrd
force-pushed
the
feature/terminal-qr-code
branch
from
September 11, 2026 06:17
df8415a to
3b8a560
Compare
…und styling - Add qrcode dependency to workspace and warpgate-common - Implement render_qr_code_terminal in warpgate-common using Unicode lower-half block (▄) and ANSI background styling to eliminate terminal line-height gaps - Add unit tests for render_qr_code_terminal
…meter and UI toggle
mtthsbrd
force-pushed
the
feature/terminal-qr-code
branch
2 times, most recently
from
September 13, 2026 09:13
f565af6 to
901a249
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qrcodecrate to workspace dependenciesrender_qr_code_terminalinwarpgate-commonusing ANSI background styling and Unicode lower half-blocks to eliminate line-height gapsm00089_ssh_show_qr_codeaddingssh_show_qr_codeto theparameterstable (defaults to true)ssh_show_qr_codeinParametersentity and Admin APIwarpgate-protocol-sshto readssh_show_qr_codefrom Parameters and render QR code alongside web authentication instructionsDescription
Sometimes the screen/computer displaying the URL for web authentication will not have a browser / copy&paste / whateverthereason. In these cases having a QR code displayed can improve UX: 1.) Scan the barcode, 2.) Authenticate on the device you scanned with 3.) Continue on terminal.
Per maintainer request, this is implemented as a dynamic parameter (
ssh_show_qr_code) with a UI toggle in the Admin console rather than a static config file option.AI Usage
Choose the level of AI involvement for this PR.
This is not to block AI contributions but rather to speed up PR review (saves time on trying to deduce the logic behind AI hallucinations).