Skip to content

Drop dead logging.properties include from jython3.test POM (#493 follow-up)#516

Open
khatchad wants to merge 1 commit into
wala:masterfrom
ponder-lab:drop-broken-logging-include-upstream
Open

Drop dead logging.properties include from jython3.test POM (#493 follow-up)#516
khatchad wants to merge 1 commit into
wala:masterfrom
ponder-lab:drop-broken-logging-include-upstream

Conversation

@khatchad
Copy link
Copy Markdown
Collaborator

@khatchad khatchad commented May 11, 2026

Summary

Closes #502.

Verification

$ ls -L jython/com.ibm.wala.cast.python.jython3.test/target/classes/logging.properties
ls: cannot access '...': No such file or directory

(After mvn clean install -DskipTests, the symlink is in target/classes/ but its readlink target doesn't exist.)

Test Plan

  • No Java/Python touched; CI catches anything genuinely broken.
  • target/classes/logging.properties no longer materializes after this change (Maven simply skips the resource).
  • Dev-time mvn -pl ... test still resolves logging.properties via the module-dir symlink — Surefire reads from the source tree, not target/classes/.

🤖 Generated with Claude Code

 follow-up).

The `<include>logging.properties</include>` line added in wala#493 packages a symlink (`jython/com.ibm.wala.cast.python.jython3.test/logging.properties` → `../logging.properties`) that resolves correctly in the module's source tree but breaks after Maven copies it as-is into `target/classes/logging.properties` — the relative target `../logging.properties` then points at `target/logging.properties`, which doesn't exist. The packaged file is therefore unreadable at runtime, and no test relies on it.

Drop the include rather than fix the symlink: the dev-time symlink remains useful for `mvn -pl ... test` runs (Surefire reads it from the module dir), but packaging it adds no value. The other test modules' POMs already omit this include and rely on the module-dir symlink alone.

Mirror of #272.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 11, 2026 14:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an explicit Maven resource include for logging.properties from the jython3.test module so builds no longer copy/package a broken symlink into target/classes, avoiding an unreadable runtime resource while keeping the narrowed resource scope introduced in #493.

Changes:

  • Drops <include>logging.properties</include> from jython/com.ibm.wala.cast.python.jython3.test/pom.xml’s build resources include-list.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.90%. Comparing base (ad96543) to head (917362c).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #516      +/-   ##
============================================
- Coverage     57.93%   57.90%   -0.03%     
+ Complexity      625      624       -1     
============================================
  Files           111      111              
  Lines          7671     7671              
  Branches        856      856              
============================================
- Hits           4444     4442       -2     
- Misses         3049     3051       +2     
  Partials        178      178              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jython3.test/logging.properties is a broken symlink; either fix or drop the resource include

2 participants