Drop dead logging.properties include from jython3.test POM (#493 follow-up)#516
Open
khatchad wants to merge 1 commit into
Open
Drop dead logging.properties include from jython3.test POM (#493 follow-up)#516khatchad wants to merge 1 commit into
logging.properties include from jython3.test POM (#493 follow-up)#516khatchad wants to merge 1 commit into
Conversation
follow-up). The `<include>logging.properties</include>` line added in wala#493 packages a symlink (`jython/com.ibm.wala.cast.python.jython3.test/logging.properties` → `../logging.properties`) that resolves correctly in the module's source tree but breaks after Maven copies it as-is into `target/classes/logging.properties` — the relative target `../logging.properties` then points at `target/logging.properties`, which doesn't exist. The packaged file is therefore unreadable at runtime, and no test relies on it. Drop the include rather than fix the symlink: the dev-time symlink remains useful for `mvn -pl ... test` runs (Surefire reads it from the module dir), but packaging it adds no value. The other test modules' POMs already omit this include and rely on the module-dir symlink alone. Mirror of #272. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an explicit Maven resource include for logging.properties from the jython3.test module so builds no longer copy/package a broken symlink into target/classes, avoiding an unreadable runtime resource while keeping the narrowed resource scope introduced in #493.
Changes:
- Drops
<include>logging.properties</include>fromjython/com.ibm.wala.cast.python.jython3.test/pom.xml’s build resources include-list.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #516 +/- ##
============================================
- Coverage 57.93% 57.90% -0.03%
+ Complexity 625 624 -1
============================================
Files 111 111
Lines 7671 7671
Branches 856 856
============================================
- Hits 4444 4442 -2
- Misses 3049 3051 +2
Partials 178 178 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<include>logging.properties</include>line that Scopejython3.test's build resource to stoptarget/self-recursing #493 added tojython/com.ibm.wala.cast.python.jython3.test/pom.xml.jython/com.ibm.wala.cast.python.jython3.test/logging.properties, which is a symlink to../logging.properties(resolves to a sibling file from the module dir).target/classes/logging.properties. The relative target../logging.propertiesthen points attarget/logging.properties, which doesn't exist — so the packaged resource is unreadable at runtime.logging.propertiesinclude fromjython3.testPOM ponder-lab/ML#272.Closes #502.
Verification
(After
mvn clean install -DskipTests, the symlink is intarget/classes/but its readlink target doesn't exist.)Test Plan
target/classes/logging.propertiesno longer materializes after this change (Maven simply skips the resource).mvn -pl ... teststill resolveslogging.propertiesvia the module-dir symlink — Surefire reads from the source tree, nottarget/classes/.🤖 Generated with Claude Code