Skip to content

feat(VOverlay): noFlip location strategy prop #22642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattgilbertnet wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat(VOverlay): noFlip location strategy prop #22642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/api-generator/src/locale/en/VOverlay-location-strategies.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"locationStrategy": "A function used to specifies how the component should position relative to its activator.",
"offset": "Increases distance from the target. When passed as a pair of numbers, the second value shifts anchor along the side and away from the target.",
"stickToTarget": "Enables the overlay content to go off-screen when scrolling.",
"viewportMargin": "Sets custom viewport margin for the overlay content"
"viewportMargin": "Sets custom viewport margin for the overlay content",
"noFlip": "When using the \"connected\" location strategy, adjust the position when needed by shifting only, not flipping."
}
}
4 changes: 3 additions & 1 deletion packages/vuetify/src/components/VOverlay/locationStrategies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ export interface StrategyProps {
maxWidth?: number | string
minHeight?: number | string
minWidth?: number | string
noFlip?: boolean
}

export const makeLocationStrategyProps = propsFactory({
Expand All @@ -80,6 +81,7 @@ export const makeLocationStrategyProps = propsFactory({
type: [Number, String],
default: 12,
},
noFlip: Boolean,
}, 'VOverlay-location-strategies')

export function useLocationStrategies (
Expand Down Expand Up @@ -430,7 +432,7 @@ function connectedLocationStrategy (data: LocationStrategyData, props: StrategyP
contentBox.y += _y

// flip
{
if (!props.noFlip) {
const axis = getAxis(placement.anchor)
const hasOverflowX = overflows.x.before || overflows.x.after
const hasOverflowY = overflows.y.before || overflows.y.after
Expand Down
Loading