Added more file size support suffixes.#171
Open
MrHamel wants to merge 1 commit into
Open
Conversation
Author
|
From the build: Clang C:
|
Contributor
|
Having these be case-insensitive makes me incredibly nervous because mega (M) and milli (m) are both valid SI prefixes and interpreting milli as mega means that you're now off by 9 orders of magnitude. |
|
You |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was writing a Python web app and it threw a parsing error when using specifying "1tb" (obviously without quotes).