Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
gatesn
commented
Mar 14, 2026
| /// Adaptor that bridges [`CompareKernel`] implementations to [`ExecuteParentKernel`] for the | ||
| /// new [`Comparison`] scalar function. | ||
| #[derive(Default, Debug)] | ||
| pub struct ComparisonCompareExecuteAdaptor<V>(pub V); |
Contributor
Author
There was a problem hiding this comment.
I hate this. we should just rewrite into the new kernel traits
Merging this PR will degrade performance by 92.63%
Performance Changes
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit: im not convinced of this PR, but the benchmarks have surfaced some interesting results. So digging in
Adds new scalar functions for comparison, arithmetic, and logical operators.
Previously the single binary function typically just switched on the logic for each of these, making it much harder to read and follow.
This also gives us more granular kernel selection, e.g. for arrays that wish to provide a comparison kernel we would previously have to invoke the kernel for any binary function.