Skip to content

fix[duckdb]: build cpp.rs only if changed#6951

Merged
joseph-isaacs merged 9 commits intodevelopfrom
ji/fix-buildrs-rebuild
Mar 16, 2026
Merged

fix[duckdb]: build cpp.rs only if changed#6951
joseph-isaacs merged 9 commits intodevelopfrom
ji/fix-buildrs-rebuild

Conversation

@joseph-isaacs
Copy link
Contributor

@joseph-isaacs joseph-isaacs commented Mar 13, 2026

Only build rust files if they change. Add a CI check for this.

The check works: #6952

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs added the changelog/fix A bug fix label Mar 13, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) March 13, 2026 17:27
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 16, 2026

Merging this PR will improve performance by 18.36%

⚡ 2 improved benchmarks
✅ 1007 untouched benchmarks
⏩ 1515 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_not_vortex_buffer_mut[128] 376.1 ns 317.8 ns +18.36%
Simulation bitwise_not_vortex_buffer_mut[1024] 535.6 ns 477.2 ns +12.22%

Comparing ji/fix-buildrs-rebuild (0640ec1) with develop (2a0d1b7)

Open in CodSpeed

Footnotes

  1. 1515 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
…fix-buildrs-rebuild

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs merged commit b59349c into develop Mar 16, 2026
54 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/fix-buildrs-rebuild branch March 16, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants