Conversation
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
…ile commands, normalize endif() Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
…pedantic) Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
0ax1
commented
Mar 12, 2026
| # `bear -- cargo build` (https://github.com/rizsotto/Bear). | ||
|
|
||
| cmake_minimum_required(VERSION 3.20) | ||
| cmake_minimum_required(VERSION 3.22) |
Contributor
Author
There was a problem hiding this comment.
Just to make the CMake version we use consistent.
0ax1
commented
Mar 12, 2026
| endif() | ||
|
|
||
| # Enable compiler warnings (matching build.rs flags). | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic -Wno-unused-parameter") |
Contributor
Author
There was a problem hiding this comment.
Note that this CMake file is not used for building only provided for people using CLion.
Merging this PR will improve performance by 11.36%
Performance Changes
Comparing Footnotes
|
myrrc
reviewed
Mar 12, 2026
|
|
||
| Expr select(const std::vector<std::string_view> &fields, Expr child) { | ||
| ::rust::Vec<::rust::String> rs_fields; | ||
| for (auto f : fields) { |
Contributor
There was a problem hiding this comment.
rs_fields.resize(fields.size());
for (size_t i = 0; i < fields.size(); ++i)
rs_fields[i] = fields[i];
myrrc
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.