Skip to content

chore: minor C++ cleanups#6913

Merged
0ax1 merged 10 commits intodevelopfrom
ad/c++cleanups
Mar 12, 2026
Merged

chore: minor C++ cleanups#6913
0ax1 merged 10 commits intodevelopfrom
ad/c++cleanups

Conversation

@0ax1
Copy link
Contributor

@0ax1 0ax1 commented Mar 12, 2026

No description provided.

0ax1 added 9 commits March 12, 2026 11:12
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
…ile commands, normalize endif()

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
…pedantic)

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 requested a review from myrrc March 12, 2026 11:39
# `bear -- cargo build` (https://github.com/rizsotto/Bear).

cmake_minimum_required(VERSION 3.20)
cmake_minimum_required(VERSION 3.22)
Copy link
Contributor Author

@0ax1 0ax1 Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make the CMake version we use consistent.

endif()

# Enable compiler warnings (matching build.rs flags).
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic -Wno-unused-parameter")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this CMake file is not used for building only provided for people using CLion.

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 added the changelog/chore A trivial change label Mar 12, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 12, 2026

Merging this PR will improve performance by 11.36%

⚡ 1 improved benchmark
✅ 993 untouched benchmarks
⏩ 1515 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation map_each[BufferMut<i32>, 128] 858.1 ns 770.6 ns +11.36%

Comparing ad/c++cleanups (41c6067) with develop (d4aa567)

Open in CodSpeed

Footnotes

  1. 1515 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@0ax1 0ax1 requested a review from robert3005 March 12, 2026 11:56
@0ax1 0ax1 enabled auto-merge (squash) March 12, 2026 11:56

Expr select(const std::vector<std::string_view> &fields, Expr child) {
::rust::Vec<::rust::String> rs_fields;
for (auto f : fields) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rs_fields.resize(fields.size());
for (size_t i = 0; i < fields.size(); ++i)
    rs_fields[i] = fields[i];

@0ax1 0ax1 merged commit ff4551f into develop Mar 12, 2026
61 of 62 checks passed
@0ax1 0ax1 deleted the ad/c++cleanups branch March 12, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants