Skip to content

Benchmarks measuring peak memory usage #6902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AdamGS wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Benchmarks measuring peak memory usage #6902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a87b518
Benchmarks measuring peak memory usage
AdamGS Mar 11, 2026
d56172a
try this thing
AdamGS Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/bench-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,19 @@ jobs:
- id: random-access-bench
name: Random Access
build_args: "--features lance"
run_args: "--formats parquet,lance,vortex"
- id: compress-bench
name: Compression
build_args: ""
run_args: "--formats parquet,lance,vortex"
- id: compress-memory-bench
name: Compression Memory
build_args: "--features dhat,lance"
run_args: "--formats parquet,vortex"
- id: tpch-datafusion-memory-bench
name: TPC-H DataFusion Memory
build_args: "--features dhat"
run_args: ""
if: ${{ contains(github.event.head_commit.message, '[benchmark]') || github.event.label.name == 'action/benchmark' && github.event_name == 'pull_request' }}
steps:
- uses: runs-on/action@v2
Expand Down Expand Up @@ -93,7 +104,7 @@ jobs:
env:
RUST_BACKTRACE: full
run: |
target/release_debug/${{ matrix.benchmark.id }} -d gh-json -o results.json
target/release_debug/${{ matrix.benchmark.id }} ${{ matrix.benchmark.run_args }} -d gh-json -o results.json

- name: Setup AWS CLI
if: github.event.pull_request.head.repo.fork == false
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,19 @@ jobs:
- id: random-access-bench
name: Random Access
build_args: "--features lance"
formats: "parquet,lance,vortex"
run_args: "--formats parquet,lance,vortex"
- id: compress-bench
name: Compression
build_args: "--features lance"
formats: "parquet,lance,vortex"
run_args: "--formats parquet,lance,vortex"
- id: compress-memory-bench
name: Compression Memory
build_args: "--features dhat,lance"
run_args: "--formats parquet,vortex"
- id: tpch-datafusion-memory-bench
name: TPC-H DataFusion Memory
build_args: "--features dhat"
run_args: ""
steps:
- uses: runs-on/action@v2
if: github.repository == 'vortex-data/vortex'
Expand Down Expand Up @@ -89,7 +97,7 @@ jobs:
env:
RUST_BACKTRACE: full
run: |
target/release_debug/${{ matrix.benchmark.id }} --formats ${{ matrix.benchmark.formats }} -d gh-json -o results.json
target/release_debug/${{ matrix.benchmark.id }} ${{ matrix.benchmark.run_args }} -d gh-json -o results.json

- name: Setup AWS CLI
uses: aws-actions/configure-aws-credentials@v5
Expand Down
121 changes: 110 additions & 11 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,11 @@ members = [
# Benchmarks
"benchmarks/lance-bench",
"benchmarks/compress-bench",
"benchmarks/compress-memory-bench",
"benchmarks/datafusion-bench",
"benchmarks/duckdb-bench",
"benchmarks/random-access-bench",
"benchmarks/tpch-datafusion-memory-bench",
"vortex-sqllogictest",
]
exclude = ["java/testfiles", "wasm-test"]
Expand Down Expand Up @@ -136,6 +138,7 @@ datafusion-physical-expr-common = { version = "52" }
datafusion-physical-plan = { version = "52" }
datafusion-pruning = { version = "52" }
datafusion-sqllogictest = { version = "52" }
dhat = "0.3.3"
dirs = "6.0.0"
divan = { package = "codspeed-divan-compat", version = "4.0.4" }
enum-iterator = "2.0.0"
Expand Down
17 changes: 17 additions & 0 deletions benchmarks-website/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ const USE_LOCAL_DATA = process.env.USE_LOCAL_DATA === "true";
const GROUPS = [
"Random Access",
"Compression",
"Compression Memory",
"Compression Size",
"TPC-H Memory",
...QUERY_SUITES.filter((s) => !s.skip && !s.fanOut).map((s) => s.displayName),
...FAN_OUT_GROUPS,
];
Expand Down Expand Up @@ -105,6 +107,21 @@ function getGroup(benchmark) {
return "Compression";
}

if (
lower.startsWith("compress peak memory/") ||
lower.startsWith("decompress peak memory/") ||
lower.startsWith("parquet_rs-zstd compress peak memory/") ||
lower.startsWith("parquet_rs-zstd decompress peak memory/") ||
lower.startsWith("lance compress peak memory/") ||
lower.startsWith("lance decompress peak memory/")
) {
return "Compression Memory";
}

if (lower.startsWith("tpch peak memory/")) {
return "TPC-H Memory";
}

// SQL query suites: match "{prefix}_q..." or "{prefix}/..."
for (const suite of QUERY_SUITES) {
if (
Expand Down
Loading
Loading