Trying some more benchmarking noise reduction things#6901
Merged
Conversation
github-actions
bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (1)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingSummary
datafusion / vortex-file-compressed (0.983x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
datafusion / vortex-file-compressed (0.854x ✅, 12↑ 0↓)
datafusion / vortex-compact (0.876x ✅, 12↑ 0↓)
datafusion / parquet (0.897x ✅, 9↑ 0↓)
datafusion / arrow (0.858x ✅, 10↑ 0↓)
duckdb / vortex-file-compressed (0.933x ➖, 6↑ 0↓)
duckdb / vortex-compact (0.951x ➖, 1↑ 0↓)
duckdb / parquet (0.977x ➖, 5↑ 3↓)
duckdb / duckdb (0.936x ➖, 9↑ 1↓)
|
Contributor
Benchmarks: FineWeb NVMeSummary
datafusion / vortex-file-compressed (0.997x ➖, 1↑ 0↓)
datafusion / vortex-compact (1.127x ❌, 0↑ 6↓)
datafusion / parquet (1.038x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (0.990x ➖, 1↑ 0↓)
duckdb / vortex-compact (1.048x ➖, 0↑ 2↓)
duckdb / parquet (1.022x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
datafusion / vortex-file-compressed (0.973x ➖, 3↑ 1↓)
datafusion / vortex-compact (0.982x ➖, 1↑ 0↓)
datafusion / parquet (0.978x ➖, 2↑ 0↓)
duckdb / vortex-file-compressed (1.009x ➖, 0↑ 1↓)
duckdb / vortex-compact (1.000x ➖, 2↑ 1↓)
duckdb / parquet (0.993x ➖, 1↑ 2↓)
duckdb / duckdb (1.005x ➖, 3↑ 3↓)
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
datafusion / vortex-file-compressed (0.900x ➖, 13↑ 0↓)
datafusion / vortex-compact (0.909x ➖, 10↑ 0↓)
datafusion / parquet (0.921x ➖, 3↑ 0↓)
datafusion / arrow (0.876x ✅, 16↑ 0↓)
duckdb / vortex-file-compressed (0.938x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.956x ➖, 0↑ 0↓)
duckdb / parquet (0.999x ➖, 0↑ 0↓)
duckdb / duckdb (0.985x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
datafusion / vortex-file-compressed (1.102x ➖, 0↑ 4↓)
datafusion / vortex-compact (0.923x ➖, 1↑ 0↓)
datafusion / parquet (0.879x ➖, 4↑ 0↓)
duckdb / vortex-file-compressed (0.998x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.038x ➖, 0↑ 0↓)
duckdb / parquet (0.996x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: FineWeb S3Summary
datafusion / vortex-file-compressed (0.905x ➖, 1↑ 0↓)
datafusion / vortex-compact (1.062x ➖, 0↑ 0↓)
datafusion / parquet (0.966x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.992x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.910x ➖, 0↑ 0↓)
duckdb / parquet (1.018x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
duckdb / vortex-file-compressed (0.948x ➖, 1↑ 0↓)
duckdb / vortex-compact (0.961x ➖, 1↑ 0↓)
duckdb / parquet (1.000x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
datafusion / vortex-file-compressed (0.980x ➖, 1↑ 1↓)
datafusion / vortex-compact (1.010x ➖, 1↑ 1↓)
datafusion / parquet (1.027x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (1.013x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.973x ➖, 0↑ 0↓)
duckdb / parquet (0.980x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Clickbench on NVMESummary
datafusion / vortex-file-compressed (0.993x ➖, 2↑ 1↓)
datafusion / vortex-compact (1.011x ➖, 2↑ 2↓)
datafusion / parquet (0.990x ➖, 3↑ 2↓)
duckdb / vortex-file-compressed (0.997x ➖, 6↑ 6↓)
duckdb / vortex-compact (0.967x ➖, 7↑ 1↓)
duckdb / parquet (1.014x ➖, 0↑ 2↓)
duckdb / duckdb (1.006x ➖, 2↑ 10↓)
|
0ax1
reviewed
Mar 11, 2026
| RUST_BACKTRACE: full | ||
| run: | | ||
| target/release_debug/${{ matrix.benchmark.id }} -d gh-json -o results.json | ||
| bash scripts/bench-taskset.sh target/release_debug/${{ matrix.benchmark.id }} -d gh-json -o results.json |
Contributor
There was a problem hiding this comment.
Unrelated to this PR, should we consider using the cargo runner env, like we do for CUDA sanitizers?
- name: CUDA - initcheck
env:
CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_RUNNER: compute-sanitizer --tool initcheck --error-exitcode 1
run: cargo test --locked -p vortex-cuda --all-features --target x86_64-unknown-linux-gnu
| - name: Pytest Benchmarks - Vortex | ||
| run: | | ||
| uv run --all-packages pytest --benchmark-only benchmark/ | ||
| bash ../scripts/bench-taskset.sh uv run --all-packages pytest --benchmark-only benchmark/ |
Contributor
There was a problem hiding this comment.
Generally not loving relative paths in scripts but 🤷
| fi | ||
|
|
||
| if command -v numactl >/dev/null 2>&1; then | ||
| exec numactl --physcpubind="$BENCH_CPUS" --localalloc "$@" |
Contributor
There was a problem hiding this comment.
Can you elaborate / add a comment why we replace the process here and for taskset? Is that the common pattern to use them?
|
|
||
| # Really discourage swapping to disk | ||
| sysctl vm.swappiness=0 | ||
| swapoff -a || true |
Contributor
There was a problem hiding this comment.
We ignore a lot of errors in this script via || true. In some way I'd like us to only run things that actually apply and otherwhise fail. We can comment out commands that don't apply to the current runner.
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
force-pushed
the
adamg/yet-more-noise-reduction
branch
from
6795276 to
d196611
Compare
0ax1
approved these changes
Mar 12, 2026
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
github-actions
bot
removed
the
action/benchmark
Contributor
Benchmarks: Random AccessSummary
unknown / unknown (1.002x ➖, 4↑ 6↓)
|
…ners Signed-off-by: Adam Gutglick <adam@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins workloads to specific cores, disables more things, turns off more features.