Skip to content

array slots#6870

Draft
joseph-isaacs wants to merge 13 commits intodevelopfrom
ji/slots-for-arrays
Draft

array slots#6870
joseph-isaacs wants to merge 13 commits intodevelopfrom
ji/slots-for-arrays

Conversation

@joseph-isaacs
Copy link
Contributor

Summary

Closes: #000

Testing

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs changed the title fix array slots Mar 10, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
# Conflicts:
#	vortex-array/src/arrays/extension/array.rs
#	vortex-array/src/arrays/extension/vtable/mod.rs
#	vortex-array/src/arrays/extension/vtable/validity.rs
@joseph-isaacs joseph-isaacs added the action/benchmark Trigger full benchmarks to run on this PR label Mar 11, 2026
@github-actions github-actions bot removed the action/benchmark Trigger full benchmarks to run on this PR label Mar 11, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 11, 2026

Merging this PR will not alter performance

✅ 170 untouched benchmarks
⏩ 2339 skipped benchmarks1


Comparing ji/slots-for-arrays (9a8769c) with develop (f29ccde)

Open in CodSpeed

Footnotes

  1. 2339 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

Polar Signals Profiling Results

Latest Run

Status Commit Job Attempt Link
🟢 Done dcc6d7e 1 Explore Profiling Data
Previous Runs (3)
Status Commit Job Attempt Link
🟢 Done 94368be 1 Explore Profiling Data
🟢 Done f7239da 1 Explore Profiling Data
🟢 Done dcfd745 1 Explore Profiling Data

Powered by Polar Signals Cloud

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark TPC-H SF=1 on NVME failed! Check the workflow run for details.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark PolarSignals Profiling failed! Check the workflow run for details.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark FineWeb NVMe failed! Check the workflow run for details.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark TPC-H SF=1 on S3 failed! Check the workflow run for details.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark TPC-DS SF=1 on NVME failed! Check the workflow run for details.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark FineWeb S3 failed! Check the workflow run for details.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark TPC-H SF=10 on NVME failed! Check the workflow run for details.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark TPC-H SF=10 on S3 failed! Check the workflow run for details.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark Clickbench on NVME failed! Check the workflow run for details.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark Statistical and Population Genetics failed! Check the workflow run for details.

joseph-isaacs and others added 2 commits March 11, 2026 15:49
…PI lock files

CI was failing because the VTable trait now requires `slots`, `slot_name`,
and `with_slots` methods, which were missing from PythonVTable.

Signed-off-by: Joe Isaacs <joe@spiraldb.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
# Conflicts:
#	vortex-array/src/vtable/mod.rs
@joseph-isaacs joseph-isaacs added action/benchmark Trigger full benchmarks to run on this PR labels Mar 11, 2026
@github-actions github-actions bot removed the action/benchmark Trigger full benchmarks to run on this PR label Mar 11, 2026
joseph-isaacs and others added 4 commits March 11, 2026 18:57
RunsOn reads config from the default branch (develop) for public
repos. Add _extends to inherit runner config from .github-private
and pin arm64 AMI for prebuilt image testing.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs added changelog/break A breaking API change action/benchmark Trigger full benchmarks to run on this PR labels Mar 12, 2026
@github-actions github-actions bot removed the action/benchmark Trigger full benchmarks to run on this PR label Mar 12, 2026
@github-actions
Copy link
Contributor

Benchmarks: Random Access

Summary

  • Overall: 1.047x ➖
  • Vortex: 0.987x ➖
  • Parquet: 1.065x ➖
unknown / unknown (1.047x ➖, 4↑ 17↓)
name PR 94368be (ns) base a1a9d77 (ns) ratio (PR/base)
random-access/feature-vectors/correlated/lance-tokio-local-disk 2248879 2422467 0.93
🚨 random-access/feature-vectors/correlated/lance-tokio-local-disk-footer 1474887 1304015 1.13
random-access/feature-vectors/correlated/parquet-tokio-local-disk 14218130825 13611567585 1.04
random-access/feature-vectors/correlated/parquet-tokio-local-disk-footer 13638552622 13365898454 1.02
random-access/feature-vectors/correlated/vortex-tokio-local-disk 8119998 7871170 1.03
random-access/feature-vectors/correlated/vortex-tokio-local-disk-footer 6065412 5789148 1.05
🚨 random-access/feature-vectors/uniform/lance-tokio-local-disk 1775640 1522997 1.17
🚨 random-access/feature-vectors/uniform/lance-tokio-local-disk-footer 2779214 2449357 1.13
random-access/feature-vectors/uniform/parquet-tokio-local-disk 13998925202 13355792971 1.05
random-access/feature-vectors/uniform/parquet-tokio-local-disk-footer 13786126066 13414675105 1.03
random-access/feature-vectors/uniform/vortex-tokio-local-disk 13021883 13954062 0.93
random-access/feature-vectors/uniform/vortex-tokio-local-disk-footer 13303617 13931938 0.95
random-access/lance-tokio-local-disk 789858 739586 1.07
random-access/lance-tokio-local-disk-footer 1492804 1371815 1.09
random-access/nested-lists/correlated/lance-tokio-local-disk 285969 271810 1.05
🚨 random-access/nested-lists/correlated/lance-tokio-local-disk-footer 841329 711491 1.18
random-access/nested-lists/correlated/parquet-tokio-local-disk 173367590 168004756 1.03
random-access/nested-lists/correlated/parquet-tokio-local-disk-footer 170825814 169325168 1.01
random-access/nested-lists/correlated/vortex-tokio-local-disk 765261 834300 0.92
random-access/nested-lists/correlated/vortex-tokio-local-disk-footer 774418 829571 0.93
🚨 random-access/nested-lists/uniform/lance-tokio-local-disk 1311655 1184868 1.11
🚨 random-access/nested-lists/uniform/lance-tokio-local-disk-footer 1890957 1676621 1.13
random-access/nested-lists/uniform/parquet-tokio-local-disk 170406228 160759114 1.06
random-access/nested-lists/uniform/parquet-tokio-local-disk-footer 169166873 164026881 1.03
random-access/nested-lists/uniform/vortex-tokio-local-disk 2583504 2552400 1.01
random-access/nested-lists/uniform/vortex-tokio-local-disk-footer 2710370 2586267 1.05
🚨 random-access/nested-structs/correlated/lance-tokio-local-disk 480340 434303 1.11
🚨 random-access/nested-structs/correlated/lance-tokio-local-disk-footer 724209 642398 1.13
🚨 random-access/nested-structs/correlated/parquet-tokio-local-disk 30677398 26616291 1.15
🚨 random-access/nested-structs/correlated/parquet-tokio-local-disk-footer 30115585 26073085 1.16
🚨 random-access/nested-structs/correlated/vortex-tokio-local-disk 952102 848254 1.12
🚨 random-access/nested-structs/correlated/vortex-tokio-local-disk-footer 1034018 879580 1.18
🚨 random-access/nested-structs/uniform/lance-tokio-local-disk 3192659 2897692 1.10
random-access/nested-structs/uniform/lance-tokio-local-disk-footer 3447066 3140324 1.10
🚨 random-access/nested-structs/uniform/parquet-tokio-local-disk 29961454 26666515 1.12
🚨 random-access/nested-structs/uniform/parquet-tokio-local-disk-footer 29929404 25667827 1.17
🚨 random-access/nested-structs/uniform/vortex-tokio-local-disk 2006724 1713068 1.17
🚨 random-access/nested-structs/uniform/vortex-tokio-local-disk-footer 1967940 1715927 1.15
random-access/parquet-tokio-local-disk 197665660 187741700 1.05
random-access/parquet-tokio-local-disk-footer 199082302 186663228 1.07
random-access/taxi/correlated/lance-tokio-local-disk 1032676 978637 1.06
random-access/taxi/correlated/lance-tokio-local-disk-footer 1793858 1684871 1.06
random-access/taxi/correlated/parquet-tokio-local-disk 293965616 279563292 1.05
random-access/taxi/correlated/parquet-tokio-local-disk-footer 292371159 277594612 1.05
random-access/taxi/correlated/vortex-tokio-local-disk 1871911 1870865 1.00
🚀 random-access/taxi/correlated/vortex-tokio-local-disk-footer 1904463 2505311 0.76
random-access/taxi/uniform/lance-tokio-local-disk 9452654 8849017 1.07
random-access/taxi/uniform/lance-tokio-local-disk-footer 10091662 9646851 1.05
random-access/taxi/uniform/parquet-tokio-local-disk 307577387 296340757 1.04
random-access/taxi/uniform/parquet-tokio-local-disk-footer 311741769 293682368 1.06
🚀 random-access/taxi/uniform/vortex-tokio-local-disk 4779460 5390614 0.89
🚀 random-access/taxi/uniform/vortex-tokio-local-disk-footer 4840609 5477070 0.88
random-access/vortex-tokio-local-disk 1356492 1246421 1.09
🚀 random-access/vortex-tokio-local-disk-footer 1354845 1726819 0.78

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs added the action/benchmark Trigger full benchmarks to run on this PR label Mar 12, 2026
@github-actions github-actions bot removed the action/benchmark Trigger full benchmarks to run on this PR label Mar 12, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs added the action/benchmark Trigger full benchmarks to run on this PR label Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action/benchmark Trigger full benchmarks to run on this PR changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant