Skip to content

WIP: Variant Type#6853

Draft
AdamGS wants to merge 11 commits intodevelopfrom
adamg/variant
Draft

WIP: Variant Type#6853
AdamGS wants to merge 11 commits intodevelopfrom
adamg/variant

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Mar 9, 2026

Just stashing results here to make the work more visible:

  1. Variant DType and Array
  2. ParquetVariant encoding
  3. VariantGet expression

@AdamGS AdamGS added the changelog/feature A new feature label Mar 9, 2026
@AdamGS AdamGS force-pushed the adamg/variant branch 2 times, most recently from 6ac96fe to 5306dd9 Compare March 10, 2026 15:00
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 10, 2026

Merging this PR will degrade performance by 10.01%

❌ 1 regressed benchmark
✅ 986 untouched benchmarks
⏩ 1512 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation binary_search_std 524.4 ns 582.8 ns -10.01%

Comparing adamg/variant (feb8635) with develop (b2d22eb)

Open in CodSpeed

Footnotes

  1. 1512 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

/// [`I32`]: PType::I32
/// [`NonNullable`]: Nullability::NonNullable
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
pub enum DType {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think we should make this #[non_exhaustive] ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding a new dtype should be very rare, but it is pretty painful to do right now.

@AdamGS AdamGS force-pushed the adamg/variant branch 2 times, most recently from 6ca0f97 to 30c8036 Compare March 10, 2026 16:14
AdamGS added 10 commits March 11, 2026 14:18
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants