Repository navigation
fix(tracing): preserve subagent trace context - #904
Open
linhongyu510 wants to merge 4 commits into
Open
linhongyu510 wants to merge 4 commits into
linhongyu510 wants to merge 4 commits into
Conversation
linhongyu510
force-pushed
the
fix/preserve-subagent-trace-context
branch
from
August 18, 2026 02:22
01286b6 to
73b9eec
Compare
Author
|
Recovery check on current main ( |
Reconcile volcengine#904 with upstream main's bounded deque retention refactor: keep main's evolved _InMemoryExporter/_InMemoryExporter.__init__ and for_provider, while retaining the subagent trace-context fix (set_span_in_context + ContextVar token cleanup). Update the RECORD_ONLY assertion to be type-agnostic to the deque retention. Tests: 6 passed.
Resolve the inmemory_exporter.py import conflict by keeping the set_span_in_context import required by the subagent trace-context fix. Upstream had already adopted the bounded span-cache refactor, so only the context-token lifecycle change from this branch is retained on top of main. Local verification: tests/tracing/test_inmemory_exporter.py (6) and tests/test_inmemory_exporter.py (12) green; ruff 0.11.12 check/format clean.
Author
Merge & local verificationMerged the latest
No CI checks are reported on this fork head; the above was verified locally against the pinned dependency set. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #549.
The in-memory span processor attached custom invocation and agent values to the OpenTelemetry context, but did not set the started span as the current span. A nested agent could therefore start without the parent agent span and receive an independent trace ID.
This change:
set_span_in_contexton_endreceives aReadableSpanRECORD_ONLYspans even though they are not exportedfinallyso exporter failures cannot leak contextValidation
tests/tracing/test_inmemory_exporter.pynow covers:ReadableSpancleanup inon_endRECORD_ONLYcleanupResults:
git diff --checkAI assistance
This change was developed with AI assistance. I reviewed the ContextVar lifecycle, verified the patch with real OpenTelemetry spans, and ran the checks above.