Skip to content

Conversation

@CosmicToast
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: briefly (objdump only)

Local build testing

  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64-musl
    • aarch64-musl (cross)

@ahesford
Copy link
Member

You've submitted a large volume of disparate updates in a short period of time. How are these tested, and are these all packages that you use regularly?

@CosmicToast
Copy link
Contributor Author

You've submitted a large volume of disparate updates in a short period of time.

I don't think ~10 is a very large volume personally. As for the short period of time, I noted that they were out of date, and then took some dedicated time specifically to bump them, make sure things run, and then submit the patches.

How are these tested, and are these all packages that you use regularly?

When I write "briefly" I mean: the tests pass with -Q on both architectures I mainly target (x86_64-musl, aarch64-musl (cross)), I run the installed version of the command / a command against the installed version of the library to make sure it still runs (e.g. in this case, I objdumped a binary and made sure nothing looks wrong).

When I write "yes" I mean: everything implied by briefly + installing the package locally and using it as I normally do (for example, in the dhcpcd submission it's installing it, rebooting the system, making sure it still correctly gets network, disconnecting, reconnecting, etc).

Yes, these are packages I use regularly : they are disparate precisely because they're packages that I actually use that are out of date. That kind of usage isn't going to follow a predefined pattern, like "all python packages" because naturally I don't use "all python packages" :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants