fix(parser): ensure dateRange uses startDate for condition#187
Open
pmendozav wants to merge 2 commits into
Open
fix(parser): ensure dateRange uses startDate for condition#187pmendozav wants to merge 2 commits into
pmendozav wants to merge 2 commits into
Conversation
|
Is there an update on this can we get it merged? |
gkatsev
previously approved these changes
Jan 28, 2025
gkatsev
dismissed
their stale review
not inherently wrong, but there's more to it
adrums86
requested changes
Jan 28, 2025
adrums86
left a comment
adrums86
left a comment
Contributor
There was a problem hiding this comment.
Thanks for submitting a fix! I agree this could be handled better. I think we might just want to be careful about possibly creating out of spec dateRange tags so lets see if we can do this as close to spec as possible.
Triggers a warn event when an EXT-X-DATERANGE tag includes both DURATION and END-DATE but lacks the required START-DATE. Ensures better HLS spec compliance.
gkatsev
approved these changes
Jan 28, 2025
adrums86
approved these changes
Feb 18, 2025
adrums86
left a comment
adrums86
left a comment
Contributor
There was a problem hiding this comment.
Obviously some karma issues that need fixed in the repo. Seems to pass locally, so its unrelated.
Author
|
Any update here? Can the change be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related with issue #186