Remove buid usage for node indexing (SYN-10508)#4909
Closed
Cisphyx wants to merge 23 commits into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## synapse-3xx #4909 +/- ##
===============================================
+ Coverage 96.47% 96.55% +0.07%
===============================================
Files 258 258
Lines 63339 63174 -165
===============================================
- Hits 61109 61000 -109
+ Misses 2230 2174 -56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
invisig0th
reviewed
May 4, 2026
| self.stormIsInPrint('refs', msgs) | ||
| self.stormIsInPrint(ip.iden(), msgs) | ||
| self.stormIsInPrint(news.iden(), msgs) | ||
| self.stormIsInPrint(str(ip.intnid()), msgs) |
Contributor
There was a problem hiding this comment.
Could this intnid() function be replaced by the assumption that every node has a .nid=<int>?
Contributor
Author
There was a problem hiding this comment.
Currently the .nid value is the encoded nid value (or None for most runt nodes)
Contributor
Author
There was a problem hiding this comment.
It is basically the equivalent of how nodes previously had .buid for internal use and .iden() for human friendly version.
OCBender
reviewed
May 4, 2026
Contributor
Author
|
Moving PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.