SYN-10461: Type handler for latlong to take input as degrees/minutes/seconds#4889
Open
MichaelSquires wants to merge 12 commits intosynapse-3xxfrom
Open
SYN-10461: Type handler for latlong to take input as degrees/minutes/seconds#4889MichaelSquires wants to merge 12 commits intosynapse-3xxfrom
MichaelSquires wants to merge 12 commits intosynapse-3xxfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## synapse-3xx #4889 +/- ##
============================================
Coverage 96.47% 96.48%
============================================
Files 259 259
Lines 63192 63259 +67
============================================
+ Hits 60967 61033 +66
- Misses 2225 2226 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
invisig0th
reviewed
Apr 14, 2026
vEpiphyte
reviewed
Apr 14, 2026
invisig0th
reviewed
Apr 14, 2026
Cisphyx
reviewed
Apr 20, 2026
| lon = parseDMS(rest) | ||
| return lat, lon | ||
| except s_exc.BadTypeValu: | ||
| continue |
Contributor
There was a problem hiding this comment.
Is it actually possible for there to be a match further if we fail to parse the first time?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.