fix: propagate configured temperature through reflect calls - #3828
Open
koriyoshi2041 wants to merge 1 commit into
Open
fix: propagate configured temperature through reflect calls#3828koriyoshi2041 wants to merge 1 commit into
koriyoshi2041 wants to merge 1 commit into
Conversation
Strix Security ReviewNo security issues found. Updated for Reviewed by Strix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
HINDSIGHT_API_LLM_TEMPERATURE_REFLECTis resolved by configuration but reflect requests omit it, so providers apply their defaults. This affects tool turns, final synthesis, structured extraction, and over-budget rewrites.Closes #3825.
Fix
Forward
llm_temperature_reflectthrough every reflect LLM call path. Add deterministic coverage for the tool loop, rewrite, and structured-output paths.Test
uv run pytest tests/test_reflect_agent.py::TestReflectStructuredOutput::test_structured_output_forwards_reflect_temperature tests/test_reflect_agent.py::TestReflectAgentMocked::test_done_tool_answer_respects_max_tokens -q(2 passed)uv run ruff check hindsight_api/engine/reflect/agent.py tests/test_reflect_agent.pyuv run ruff format --check hindsight_api/engine/reflect/agent.py tests/test_reflect_agent.pygit diff --checkThe full reflect-agent file also passed 45 tests; four environment-dependent tests could not start because the local checkout lacks
pg0-embeddedand provider credentials. The repository-wide lint wrapper reached unrelated TypeScript linting and stopped because workspace npm dependencies were not installed.Risk
Low. The provider interfaces already accept optional temperature values, and the default remains
None, preserving existing provider-default behavior when the setting is unset.