feat: add escrow withdrawal support - #186
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Focused tests could not run because dependencies are not installed ( |
Tests couldn’t run because |
|
No actionable issues found. Non-blocking: add tests for exact |
|
No issues found in the incremental change. The tests correctly cover inclusive |
Assisted-by: AI
427b72f to
5162bf3
Compare
Tests could not run because dependencies/Vitest are not installed. |
Assisted-by: AI
|
No findings in the incremental diff. The new rejection typing and runtime validation are consistent. Validation note: tests could not run because dependencies are not installed ( |
Expose the definite withdrawal rejection error from the public node and browser entrypoints so consumers can handle the SDK error class reliably. Assisted-by: AI
|
No findings in the incremental diff. The error and related types are exported consistently from browser and Node entry points. Validation note: typecheck couldn’t run because dependencies are incomplete ( |
Cover the required deadline field in the confirmed withdrawal response fixture and assert that the SDK returns the request deadline unchanged. Assisted-by: AI
a42c41a to
7901b94
Compare
|
No findings. The before and after commits have identical trees, so this push introduces no code changes to review. |
Expose the gateway's per-asset withdrawal floor so callers can avoid below-minimum requests without duplicating protocol policy. Preserve null when no floor is configured and cover both balance response paths.\n\nAssisted-by: AI
|
No actionable issues found in the incremental diff. The nullable field is consistently added to the public type and both balance response fixtures. |
Expose the gateway's chain-scoped nonce snapshot through the escrow client. Validate account identity and nonce invariants while preserving the existing optimistic stale-nonce retry contract. Assisted-by: AI
Git exports repository context to push hooks. Clear it before reading the pinned policy checkout so validation checks the intended repository.\n\nAssisted-by: AI
|
The escrow account identifies the debit and payout target. The gateway may also authorize the confirmed owner of a registered app to sign. Assisted-by: AI
|
No findings. The documentation now correctly separates the withdrawal recipient/account from the gateway-authorized signer policy. |
|
FYI: |
2 participants
Adds SDK support for Data Gateway escrow withdrawals on top of the current paid-read SDK surface.
Scope
WithdrawAuthorizationmessages withaccount,asset,amount,withdrawNonce, anddeadline.EscrowGatewayClient.withdrawwith typed submitted, confirmed, finalized, retryable, reorged, and failed lifecycle results.withdrawingAmountandavailableAmount.Validation
git diff --checkpassed against currentorigin/main.Dependency
This SDK surface depends on the matching Data Gateway withdrawal endpoint in data-gateway#67. It is ready for compile-time, mocked, and integration preparation work, but stable release should wait until #67 is merged, deployed, and verified with the live-chain withdrawal test.
Assisted-by: AI