fix: accept enclave grants on consent return - #2
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Kahtaf
marked this pull request as ready for review
September 8, 2026 17:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A URL-less enclave grant reached
ready_for_read, but the consent return page reported “Status unavailable” because its readiness check still required a Personal Server URL.Make the default readiness check use the same enclave-routing decision as the status and read routes. Direct delivery and explicit URL requirements remain enforced, along with approved-state and grant-presence checks.
Stacked on #1 at
ff49c73. Validation: focused regression failed withDIRECT_ACCESS_NOT_APPROVEDbefore the fix; all 39 tests and production build passed; independent Codex review found no actionable defects. Live Preview reproduction confirmed the failure before the change. The deployed return URL for the original approved grant now reports “Your data is ready.”Live E2E passed on commit
bb2b8d912f87fd74896b2bd7764637bec874f5b4, deploymentdpl_2jisRLMWjft5k8NzQ6UBuXc6NZAaat the enclave Preview. Defaults are explicitly dev/Moksha, with the existing Friday spike gateway and Web Preview aliases.Final Spotify-only DCR
dcr_bdd21113543540a08bc348868edc6546reached completion HTTP 200, this deployment's read HTTP 200, and acknowledgement HTTP 200. Job8f6d4dea-a27d-436e-abb6-43a893538993completed onspike-b3-f1, attempt 1, chain 14800, in 6.198 seconds; encrypted request/result present, result ciphertext 577 bytes. The originating browser rendered “A first page, written,” and the consent tab returned “Your page is ready.”The integration uses Web PR #1029 plus its archived Friday-only gateway config patch, which is outside that PR. No Account/Gateway redeployment, CVM restart, production change or merge was performed. No private portrait content is included here.
Folded by fast-forward into #1’s head branch
feat/enclave-jobs-readat tested commitbb2b8d912f87fd74896b2bd7764637bec874f5b4on 2026-09-08 17:46:38 UTC. #1 remains open; main was not merged.