tsort stdout flushing fix and several error messages handling ameliorations - #14384
tsort stdout flushing fix and several error messages handling ameliorations #14384anastygnome wants to merge 1 commit into
Conversation
43f3f67 to
9a6fccd
Compare
Merging this PR will regress 1 benchmark
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
|
welp, bench seemed like they had a cache issue on their test machine? The perf reg is in the allocator for IntVec |
|
GNU testsuite comparison: |
|
this is good to merge, and should asap, currently all write errors are gobbled. |
7c7de80 to
6d79017
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
e35bd6d to
d20dd35
Compare
|
I agree your solution is better in terms of error management, I have autosquashed the commit and put us both as coauthors :) |
|
The CI failure is unrelated |
This comment was marked as outdated.
This comment was marked as outdated.
… error handling Co-authored-by: Author: xtqqczze <45661989+xtqqczze@users.noreply.github.com>
fixes #14383
fixes #12006
closes #12065
The HEAD tsort added buffering but did not check whether writing was successful or not. I
I added the fix and modified the locale to make the names use generic constants.