Skip to content

tsort stdout flushing fix and several error messages handling ameliorations - #14384

Open
anastygnome wants to merge 1 commit into
uutils:mainfrom
anastygnome:tsort
Open

tsort stdout flushing fix and several error messages handling ameliorations #14384
anastygnome wants to merge 1 commit into
uutils:mainfrom
anastygnome:tsort

Conversation

@anastygnome

@anastygnome anastygnome commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

fixes #14383
fixes #12006
closes #12065

The HEAD tsort added buffering but did not check whether writing was successful or not. I
I added the fix and modified the locale to make the names use generic constants.

@anastygnome
anastygnome force-pushed the tsort branch 5 times, most recently from 43f3f67 to 9a6fccd Compare September 4, 2026 12:50
@codspeed-hq

codspeed-hq Bot commented Sep 4, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 365 untouched benchmarks
⏩ 50 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation mv_directory 8.2 ms 8.5 ms -3.57%
Simulation mv_force_overwrite 177.9 ms 148 ms +20.24%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing anastygnome:tsort (62bf93f) with main (9ff4114)

Open in CodSpeed

Footnotes

  1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@anastygnome

anastygnome commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

welp, bench seemed like they had a cache issue on their test machine? The perf reg is in the allocator for IntVec

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/pipe-f is now passing!

@anastygnome

Copy link
Copy Markdown
Contributor Author

@sylvestre
@cakebaker

this is good to merge, and should asap, currently all write errors are gobbled.

@anastygnome anastygnome changed the title Tsort stdout flushing fix and several error messages handling ameliorations tsort stdout flushing fix and several error messages handling ameliorations Sep 4, 2026
@anastygnome
anastygnome force-pushed the tsort branch 6 times, most recently from 7c7de80 to 6d79017 Compare September 5, 2026 09:22
@xtqqczze

This comment was marked as resolved.

Comment thread src/uu/tsort/src/tsort.rs Outdated
@xtqqczze

This comment was marked as resolved.

@anastygnome
anastygnome force-pushed the tsort branch 4 times, most recently from e35bd6d to d20dd35 Compare September 5, 2026 17:02
@anastygnome

Copy link
Copy Markdown
Contributor Author

I agree your solution is better in terms of error management, I have autosquashed the commit and put us both as coauthors :)

@anastygnome
anastygnome requested a review from xtqqczze September 5, 2026 17:08
@anastygnome

Copy link
Copy Markdown
Contributor Author

The CI failure is unrelated

Comment thread src/uu/tsort/src/error.rs Outdated
@xtqqczze

This comment was marked as outdated.

… error handling

Co-authored-by: Author: xtqqczze <45661989+xtqqczze@users.noreply.github.com>
@xtqqczze

xtqqczze commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tsort regression introduced after stdout buffer addition tsort file > /dev/full panics

2 participants