test(unikontainers): add unit tests for pure functions#723
Open
mdryaan wants to merge 1 commit into
Open
Conversation
Signed-off-by: Md Raiyan <alikhurshid842001@gmail.com>
✅ Deploy Preview for urunc canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for three sets of pure functions in
pkg/unikontainersthat have real conditional logic but no test coverage.TestMapRootfsPropagationFlag—mount_test.goCovers all 8 valid propagation flag names (shared,rshared,slave,rslave,private,rprivate,unbindable,runbindable) asserting the exact unix flag value returned, plus one subtest for an unknown value asserting a non-nil error.TestChooseTmpfsSize—shared_fs_test.goCovers the 9pfs constant path, two virtiofs cases with typical memory (256 MB, 512 MB) verifying the MiB-to-MB conversion and 1 MiB overhead, and the zero-memory edge case.TestInt32msgSerialize/TestBytemsgSerialize—ipc_message_test.goCovers int32msg serialization (length, type, and value fields at thecorrect byte offsets) and bytemsg serialization (aligned buffer length, header fields, value bytes). Includes a subtest for the oversized-value panic path in bytemsg that asserts anetlinkErroris raised whenLen()exceedsmath.MaxUint16.Related issues
How was this tested?
go test -count=1 ./pkg/unikontainers/... -v
-run "TestMapRootfsPropagationFlag|TestChooseTmpfsSize|TestInt32msgSerialize|TestBytemsgSerialize"
All 16 subtests pass. Linter passes (
make lint, 0 issues).Build passes (
make).LLM usage
Claude Sonnet 4.6 was used to assist in identifying untested functions and understanding the codebase structure. All code was manually reviewed and understood before submission.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).