chore: Be more precise when talking about network shield/relay#222
Open
danielvallance wants to merge 1 commit into
Open
chore: Be more precise when talking about network shield/relay#222danielvallance wants to merge 1 commit into
danielvallance wants to merge 1 commit into
Conversation
danielvallance
temporarily deployed
to
pull-requests
GitHub Actions
Inactive
unikraft-bot
reviewed
Jul 9, 2026
|
|
||
| The network shield feature provides the ability to transparently insert a “shield” between a microVM and the public Internet. | ||
| A relay redirects all network traffic to and from a network interface toward another network interface. | ||
| This lets you set up a dedicated relay VM and configure its interface as the relay for another VM's interface, so that all of the other VM's traffic transparently passes through the relay. |
Contributor
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Microsoft.SentenceLength] Try to keep sentences short (< 30 words).
|
|
||
| The network shield feature provides the ability to transparently insert a “shield” between a microVM and the public Internet. | ||
| A relay redirects all network traffic to and from a network interface toward another network interface. | ||
| This lets you set up a dedicated relay VM and configure its interface as the relay for another VM's interface, so that all of the other VM's traffic transparently passes through the relay. |
Contributor
There was a problem hiding this comment.
🚫 [vale] reported by reviewdog 🐶
[Microsoft.Wordiness] Consider using 'all' instead of 'all of'.
|
|
||
| The network shield feature provides the ability to transparently insert a “shield” between a microVM and the public Internet. | ||
| A relay redirects all network traffic to and from a network interface toward another network interface. | ||
| This lets you set up a dedicated relay VM and configure its interface as the relay for another VM's interface, so that all of the other VM's traffic transparently passes through the relay. |
Contributor
There was a problem hiding this comment.
🚫 [vale] reported by reviewdog 🐶
[write-good.TooWordy] 'all of' is too wordy.
| } | ||
| ``` | ||
|
|
||
| A network shield is one example of a relay: it sits between a microVM and the public Internet, filters traffic, and can inject credentials or secrets for agentic and other use cases. |
Contributor
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Microsoft.SentenceLength] Try to keep sentences short (< 30 words).
| ``` | ||
|
|
||
| A network shield is one example of a relay: it sits between a microVM and the public Internet, filters traffic, and can inject credentials or secrets for agentic and other use cases. | ||
| A first network shield image will be available soon, and the example above can then be updated to use it. |
Contributor
There was a problem hiding this comment.
🚫 [vale] reported by reviewdog 🐶
[write-good.Passive] 'be updated' may be passive voice. Use active voice if you can.
Signed-off-by: Daniel Vallance <daniel@unikraft.com>
danielvallance
force-pushed
the
danielvallance/shield_relay_rename
branch
from
c47b690 to
2503ec7
Compare
dragosgheorghioiu
approved these changes
Jul 10, 2026
dragosgheorghioiu
left a comment
dragosgheorghioiu
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Reviewed-by: Dragos Gheorghioiu dragosg@unikraft.com
Approved-by: Dragos Gheorghioiu dragosg@unikraft.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.