fix: use DOMParser instead of innerHTML in process_iframes#1796
Open
Br1an67 wants to merge 1 commit intounclecode:mainfrom
Open
fix: use DOMParser instead of innerHTML in process_iframes#1796Br1an67 wants to merge 1 commit intounclecode:mainfrom
Br1an67 wants to merge 1 commit intounclecode:mainfrom
Conversation
Sites with Trusted Types CSP block direct innerHTML assignment. Replace with DOMParser.parseFromString() which is Trusted Types-safe and moves parsed child nodes into the replacement div. Closes unclecode#1582
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1582
Sites with Trusted Types Content Security Policy (like Google properties) block direct
innerHTMLassignment, causingTypeError: Failed to set the 'innerHTML' property on 'Element': This document requires 'TrustedHTML'.Replaced
div.innerHTML = ...withDOMParser.parseFromString()which parses the HTML safely and moves child nodes into the replacement div without triggering the Trusted Types policy.List of files changed and why
crawl4ai/async_crawler_strategy.py— Inprocess_iframes(), replacedinnerHTMLassignment withDOMParser+ DOM node transfer approach.How Has This Been Tested?
Verified the DOMParser approach produces equivalent DOM output to innerHTML while being Trusted Types-safe. DOMParser is supported in all modern browsers.
Checklist: