fix: make link_preview_timeout configurable in AdaptiveConfig#1793
Open
Br1an67 wants to merge 1 commit intounclecode:mainfrom
Open
fix: make link_preview_timeout configurable in AdaptiveConfig#1793Br1an67 wants to merge 1 commit intounclecode:mainfrom
Br1an67 wants to merge 1 commit intounclecode:mainfrom
Conversation
The timeout for link preview extraction in _crawl_with_preview was hardcoded to 5 seconds. Add link_preview_timeout field to AdaptiveConfig (defaults to 5.0 for backward compatibility) and use it in the LinkPreviewConfig. Closes unclecode#1659
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1659
The
timeoutforLinkPreviewConfiginAdaptiveCrawler._crawl_with_previewwas hardcoded to 5 seconds. This adds alink_preview_timeoutfield toAdaptiveConfig(defaults to5.0for backward compatibility) and wires it through.List of files changed and why
crawl4ai/adaptive_crawler.py— Addedlink_preview_timeout: float = 5.0toAdaptiveConfigand replaced the hardcodedtimeout=5withself.config.link_preview_timeout.How Has This Been Tested?
Verified that the default value (
5.0) preserves existing behavior, and that setting a custom value (e.g.AdaptiveConfig(link_preview_timeout=15)) correctly propagates toLinkPreviewConfig.Checklist: