fix: enable wait_for_images on /screenshot endpoint#1792
Open
Br1an67 wants to merge 1 commit intounclecode:mainfrom
Open
fix: enable wait_for_images on /screenshot endpoint#1792Br1an67 wants to merge 1 commit intounclecode:mainfrom
Br1an67 wants to merge 1 commit intounclecode:mainfrom
Conversation
The /screenshot endpoint did not set wait_for_images in CrawlerRunConfig, so images were not waited for before capture. Add wait_for_images param to ScreenshotRequest (defaults to True) and pass it through to the config. Closes unclecode#1657
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1657
The
/screenshotendpoint created aCrawlerRunConfigwithoutwait_for_images, so images were not loaded before capturing the screenshot. This caused broken/missing images in screenshots.List of files changed and why
deploy/docker/schemas.py— Addedwait_for_imagesfield toScreenshotRequest(defaults toTrue)deploy/docker/server.py— Passwait_for_imagesfrom request body toCrawlerRunConfigHow Has This Been Tested?
Verified that the
CrawlerRunConfignow receiveswait_for_images=Trueby default, which triggers the image-loading wait logic in_crawl_webbefore screenshot capture.Checklist: