fix: respect scan_full_page=False for viewport-only screenshots#1791
Open
Br1an67 wants to merge 1 commit intounclecode:mainfrom
Open
fix: respect scan_full_page=False for viewport-only screenshots#1791Br1an67 wants to merge 1 commit intounclecode:mainfrom
Br1an67 wants to merge 1 commit intounclecode:mainfrom
Conversation
When scan_full_page is False, take_screenshot now returns a viewport-only screenshot via take_screenshot_naive instead of always stitching a full-page image when the page exceeds the viewport height. Closes unclecode#1750
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1750
When
scan_full_page=False,take_screenshot()still produced a full-page stitched screenshot becausepage_need_scroll()always triggeredtake_screenshot_scrollerfor pages taller than the viewport. Now, whenscan_full_page=False,take_screenshot()directly callstake_screenshot_naive()which captures only the viewport area at the configured resolution.List of files changed and why
crawl4ai/async_crawler_strategy.py— Passscan_full_pagefrom config totake_screenshot(); skip scroll-based stitching whenscan_full_page=Falseand return viewport-only screenshot.How Has This Been Tested?
Verified the logic flow: with
scan_full_page=False,take_screenshot()now returns early withtake_screenshot_naive()which usespage.screenshot(full_page=False)— capturing exactly the viewport dimensions.Checklist: