fix: strip markdown code fences from LLM JSON responses#1787
Open
Br1an67 wants to merge 1 commit intounclecode:mainfrom
Open
fix: strip markdown code fences from LLM JSON responses#1787Br1an67 wants to merge 1 commit intounclecode:mainfrom
Br1an67 wants to merge 1 commit intounclecode:mainfrom
Conversation
Some LLM providers (notably Claude) wrap JSON responses in markdown code fences even when JSON mode is requested. This causes json.loads to fail with JSONDecodeError. Add a _strip_markdown_json helper that removes ```json....``` fences before parsing. Applied to generate_schema (sync+async) and the main extraction methods. Fixes unclecode#1663
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some LLM providers (notably Claude Sonnet) wrap JSON responses in markdown code fences (
json....) even when JSON mode is requested. This causesjson.loads()to fail withJSONDecodeErroringenerate_schema()and the main extraction methods.This PR adds a
_strip_markdown_json()helper that detects and removes markdown fences before parsing. Applied to:generate_schema()(sync)agenerate_schema()(async)_perform_extraction()sync and async pathsFixes #1663
List of files changed and why
crawl4ai/extraction_strategy.py— Added_strip_markdown_json()helper and applied it to alljson.loads()calls on LLM responsesHow Has This Been Tested?
Verified locally with test cases covering:
json\n{...}\n(json-tagged fences)\n{...}\n(untagged fences)Checklist: